Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --log-dir switch to adapter #1653

merged 2 commits into from Aug 3, 2019


Copy link

commented Aug 3, 2019

No description provided.

@karthiknadig karthiknadig requested a review from int19h Aug 3, 2019

help="enable logging and use DIR to save adapter logs"

This comment has been minimized.

Copy link

int19h Aug 3, 2019


If I'm reading this right, it would allow --log-dir without any command line argument, in which case it sets it to None, which disables it. I don't think that's what somebody who just said --log-dir would intend it to do.

So I think the argument should be mandatory - so no nargs and no default.


int19h approved these changes Aug 3, 2019

@karthiknadig karthiknadig merged commit ebf4629 into microsoft:dbg_adapter_refactor Aug 3, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
ptvsd-testing-automation #20190802.4 failed
license/cla All CLA requirements met.

@karthiknadig karthiknadig deleted the karthiknadig:logswitch branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.