Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1648, #1678, #1679, #1680 #1681

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@int19h
Copy link
Contributor

commented Aug 12, 2019

No description provided.

Use a separate exception type NoMoreMessages to indicate end-of-strea…
…m for JSON messaging, to avoid leaking EOFError from disk I/O or from another stream not being properly reported as errors.

@int19h int19h requested a review from karthiknadig Aug 12, 2019

@int19h int19h force-pushed the int19h:1648 branch from cf748c5 to c5fe515 Aug 12, 2019

@int19h int19h force-pushed the int19h:1648 branch from c5fe515 to d4f2fbb Aug 12, 2019

Fix #1648: Messaging does not allow reverse requests
Separate message parsing and message handling into separate threads.

Remove nested message handling in request handlers via `yield`, since it is incompatible with the new split model, and replace it with NO_RESPONSE and Request.respond() to defer responses until later.

Change Message.cant_handle() and Message.isnt_valid() to respond to the request and return the exception, instead of raising it, to accommodate NO_RESPONSE scenarios where a failure needs to be reported later.

Fix #1678: Do not rely on "processId" being returned by "runInTerminal" request

Extract debuggee PID from the "process" event sent by the debug server.

Fix #1679: "exited" event sometimes reports "exitCode": null

Report it as -1 if it cannot be retrieved from the debuggee process.

Fix #1680: Fatal errors in message loop do not fail fast

os._exit() immediately if a fatal error occurs in message parsing or message handling background threads.

@int19h int19h force-pushed the int19h:1648 branch from d4f2fbb to 2b14089 Aug 12, 2019

@int19h int19h merged commit 981b1d1 into microsoft:dbg_adapter_refactor Aug 12, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ptvsd-testing-automation #20190811.4 failed
Details
license/cla All CLA requirements met.
Details

@int19h int19h deleted the int19h:1648 branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.