Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that messages are sent before shutdown. Fixes #1813 #1832

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@fabioz
Copy link
Collaborator

commented Oct 8, 2019

Also fixes deadlock with fork.

Also fixes deadlock with fork.
pydevd_constants.after_fork()
pydevd_constants.DebugInfoHolder.DEBUG_STREAM = NULL

# TODO: We should use the pid for logging in pydevd to deal with multiple processes.

This comment has been minimized.

Copy link
@fabioz

fabioz Oct 8, 2019

Author Collaborator

Note: I created #1831 to address this properly.

@fabioz fabioz requested review from karthiknadig and int19h Oct 9, 2019
@int19h
int19h approved these changes Oct 9, 2019
@fabioz fabioz merged commit a4892f4 into microsoft:master Oct 10, 2019
3 of 4 checks passed
3 of 4 checks passed
ptvsd-testing-automation #20191008.1 failed
Details
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@fabioz fabioz deleted the fabioz:ptvsd_1813_send_response branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.