Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiplayer: on ipad "host multiplayer game" button doesn't #5500

Open
eanders-ms opened this issue Jan 13, 2023 · 3 comments · Fixed by microsoft/pxt#9326
Open

multiplayer: on ipad "host multiplayer game" button doesn't #5500

eanders-ms opened this issue Jan 13, 2023 · 3 comments · Fixed by microsoft/pxt#9326
Assignees
@eanders-ms
Labels
browser compat bug Something isn't working multiplayer p2

Comments

@eanders-ms
Copy link
Contributor

iPad Mini, private tab, not logged in.

  1. In a project, use a multiplayer block
  2. Click the "Host multiplayer game" button
  3. Follow the share dialog prompts
  • Expect: Multiplayer page would launch in a new tab
  • Actual: No new tab opens.
@eanders-ms
Copy link
Contributor Author

Repros in regular tab (not private)

@eanders-ms
Copy link
Contributor Author

In Safari on MacOS: the pop up is blocked. Could it be due to the aka.ms link breaking same-domain rules?

@eanders-ms eanders-ms self-assigned this Jan 13, 2023
@abchatra abchatra added bug Something isn't working p2 labels Jan 18, 2023
@abchatra abchatra added this to the Jan-winter-Release milestone Jan 18, 2023
@eanders-ms
Copy link
Contributor Author

Option: use relative link (skip aka).

@eanders-ms eanders-ms mentioned this issue Jan 25, 2023
Merged
@eanders-ms eanders-ms reopened this Jan 25, 2023
@eanders-ms eanders-ms removed this from the Hotfix milestone milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eanders-ms eanders-ms

Labels
browser compat bug Something isn't working multiplayer p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support relative links in multiplayer urls microsoft/pxt
2 participants
@abchatra @eanders-ms