Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upmake sprite collisions register events with all tiles touched #920
Conversation
| @@ -732,10 +732,9 @@ class Sprite extends sprites.BaseSprite { | |||
| } | |||
|
|
|||
| registerObstacle(direction: CollisionDirection, other: sprites.Obstacle) { | |||
| if (other == undefined) return; | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwunderl
Aug 13, 2019
Author
Collaborator
Ahh I should have mentioned this one, TileMap.getObstacle can no longer return undefined after the physics interpolation changes, so this is now a redundant check. I just noticed that it while moving stuff around above.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jwunderl commentedAug 9, 2019
•
edited
Currently, only the top most / left most wall that a sprite is touching has it's collision event trigger, which feels weird as the sprite is hitting multiple tiles but only counting collisions for one of them seemingly arbitrarily.
This defers the wall collision handling until after each tile the sprite would be touching has been checked, and then runs the collision events for each of them, instead of backing out after the first one.
fixes microsoft/pxt-arcade#1185 (except the sub issue of a request for non-bounding box based tile collisions, which I don't think will be feasible for now at least.)
worth a note this will cause a minor change in the block above's behavior (will return the rightmost collided tile instead of the leftmost), but that behavior wasn't defined / generally understood before anyways. I think that one might be good to change in the future, maybe just to be an option on the
is hitting wallblock that takes a parameter for the type of wall (e.g so you can check if it's hitting a lava tile); I don't think there's really anything valuable you can do with the block currently (without going to ts), and haven't seen it used (that I remember).