Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore core package dependencies in the API info #6195

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@riknoll
Copy link
Member

riknoll commented Nov 7, 2019

This PR #6179 caused an issue in Arcade where the colors didn't match up on a few of the categories. Fixing that!

@riknoll riknoll requested review from jwunderl, darzu and shakao Nov 7, 2019
@riknoll riknoll merged commit e52e6fb into master Nov 7, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@riknoll riknoll deleted the ignore-core-deps branch Nov 7, 2019
emilyemorehouse added a commit to littlebitselectronics/pxt that referenced this pull request Nov 12, 2019
* master: (64 commits)
  5.28.17
  Fix python compile issues for Arcade (microsoft#6167)
  Turns on strict-null-checking in pxtpy/ (microsoft#6125)
  5.28.16
  Blockly merge (part 1) (microsoft#6192)
  Include docs in bundledDirs in static package (microsoft#6196)
  add doc header field to apptheme (microsoft#6078)
  language picker in docs (microsoft#6064)
  localized button label (microsoft#6197)
  Option for Custom Button-Labels in CodeCards (microsoft#6168)
  support for setting large image as .mp4 (microsoft#6187)
  Undust package page (microsoft#6189)
  Stay in editor after loading tutorial from hash (microsoft#6191)
  Changing the MemTranslationDb time entry (microsoft#6188)
  Ignore core package dependencies in the API info (microsoft#6195)
  Decompile element access in conditional expression to blocks (microsoft#6190)
  Make 'pxt builddaldts' generate something even if build fails (microsoft#6183)
  Order .h files before .cpp/.c etc when parsing (microsoft#6185)
  show whitespace button (microsoft#6186)
  5.28.15
  ...
abchatra added a commit that referenced this pull request Nov 15, 2019
* Build api info for bundled packages as part of the target build (#6163)

* pre-cache api info for built-in packages

* Use corepkg instead of blocksprj for the api info base

* Cache API info for external packages in indexeddb (#6174)

* Cache API info for external packages in indexeddb

* Linting

* don't crash on --rebundle (#6178)

* don't crash on --rebundle

* return null from cachedApiInfo if nothing bundled

* can't length a map

* Fixing two API cache bugs (#6179)

* Allow built-in packages to override the APIs in core

* Don't use cached info if the user project could have blocks

* Ignore core package dependencies in the API info (#6195)

* Add defaults when loading api cache, and remove them when saving (#6200)

* Add defaults when loading api cache, and remove them when saving

* Minor tweaks

* Fix crash

* Adding flag to disable api caching (#6208)

* Revert "Add defaults when loading api cache, and remove them when saving (#6200)"

This reverts commit 00db5d0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.