Update playground to load blocks in iframe instead of custom sandbox #7241
Conversation
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
| sampleSwitcher.appendChild(sampleChapter); | ||
| ] | ||
| }, { | ||
| name: "LEGO EV3", |
There was a problem hiding this comment.
You could load the editors.json for list of editors (since you are cleaning)
| language: "typescript", | ||
| minimap: { enabled: false } | ||
| }); | ||
| var targets = [ |
There was a problem hiding this comment.
I've also refactored our list of editors in the 'editors.json" file, which you can fetch. WOuld be good to eventually unify all these tools to use the same list of editors.
docs/static/playground/playground.js
Outdated
| ] | ||
| } | ||
| ]; | ||
| var CUSTOM_FILE = "_custom.ts"; |
There was a problem hiding this comment.
why not just "custom.ts" ? (not that it matters at all)
There was a problem hiding this comment.
oh i use the underscore for files that users shouldn't modify, i feel like it makes the file look less... friendly? just habit in this case haha
There was a problem hiding this comment.
the editor creates a "custom.ts" file so let's drop the _
| for (var _a = 0, _b = target.endpoints; _a < _b.length; _a++) { | ||
| var endpoint = _b[_a]; | ||
| if (!selected || selected === target.name + "-" + endpoint.name) { | ||
| iframe.setAttribute("src", endpoint.url); |
There was a problem hiding this comment.
add ws=mem to avoid polluting the script list of the user.
There was a problem hiding this comment.
updated! i'll make a separate pr after this one to use editors.json, it's not a lot of code but i want to add some targets to the json so i might tweak streamer to add a list of disabled targets
There was a problem hiding this comment.
you can add a flag in editors.json to specify that it is supported in particular tool...
"microbit": {
"tutorial-tool": true,
...
}
to avoid interference
docs/static/playground/playground.ts
Outdated
| } | ||
| ]; | ||
|
|
||
| const CUSTOM_FILE = "_custom.ts"; |
There was a problem hiding this comment.
updated! i ended up removing ws=mem because it isn't compatible with controller=1, and controller=1 also does not pollute the user's real projects
I checked that all samples load correctly in Arcade (beta), except the text dropdown, which I think is probably due to blockly upgrade issues--I'll investigate separately.
For microsoft/pxt-arcade#1942