Get rid of extraneous dependencies to resurrect the ---asseteditor page #8550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks way, way, scarier than it actually is! All this PR does is move things around a bit to make our dependency graph a little less complicated. Basically, the /---asseteditor page broke a while back when the cloudsync stuff went in. Obviously the cloudsync stuff shouldn't even be in the /---asseteditor page at all, so I had to untangle our imports a bit.
The big culprit was
fireClickOnEnter
which we use all over the place and is exported bysui.tsx
(which itself requiresapp.tsx
). I factored that out into a new file along with some of the asset editor utils that were also drawing inpackage.ts
for no good reason.To fix this, I wrote a script to trace the dependency graph and figure out the culprit. Here's how the dependency graph looked for the
package.ts
issues: