Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure workspace/configuration capability was sent by the client before using the call #1505

Closed
jakebailey opened this issue Sep 4, 2019 · 0 comments · Fixed by #1506

Comments

@jakebailey
Copy link
Member

commented Sep 4, 2019

#1492 uses the workspace/configuration call back to the client in order to fetch the configuration earlier than the client would normally send it.

Unfortunately, I missed the fact that this functionality is optional and needs to be gated against a client capability.

/**
 * Workspace specific client capabilities.
 */
export interface WorkspaceClientCapabilities {
	// ...
	/**
	 * The client supports `workspace/configuration` requests.
	 *
	 * Since 3.6.0
	 */
	configuration?: boolean;

If the client doesn't say it has this request, we can't call it and have to resort to the double-reload configuration change (if we want to really get rid of searchPaths in the initialization options).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.