Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to function when property's declaringType is unknown #1416

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@jakebailey
Copy link
Member

commented Aug 7, 2019

Fixes #1335, for now.

This could stand to be improved by somehow allowing the declaring type to be null, but that is a more complicated fix, and just falling back to a function provides some usability and stops the NREs.

@jakebailey jakebailey requested a review from MikhailArkhipov Aug 7, 2019

@jakebailey jakebailey merged commit 2cab4fd into microsoft:master Aug 7, 2019

1 check passed

license/cla All CLA requirements met.
Details

@jakebailey jakebailey deleted the jakebailey:fix-1335 branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.