Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class member lock protection #1491

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@MikhailArkhipov
Copy link
Member

commented Aug 27, 2019

Fixes #1489

Add lock protection to class members and bases.

@MikhailArkhipov MikhailArkhipov requested a review from AlexanderSher Aug 27, 2019

public IReadOnlyList<IPythonType> Bases {
get {
lock(_membersLock) {
return _bases.ToArray();

This comment has been minimized.

Copy link
@jakebailey

jakebailey Sep 3, 2019

Member

_bases can be null, so this fails the tests.

@jakebailey
Copy link
Member

left a comment

Tests pass now.

@MikhailArkhipov MikhailArkhipov merged commit 22832f7 into master Sep 3, 2019

1 check passed

license/cla All CLA requirements met.
Details

@MikhailArkhipov MikhailArkhipov deleted the 1489 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.