Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpacking typing Tuples and Lists correctly #1498

Merged
merged 20 commits into from Sep 16, 2019

Conversation

@CTrando
Copy link
Contributor

commented Aug 31, 2019

Fixes #1457
Fixes #1494
Fixes #411
Fixes #1382
Fixes #1293

Also swapped all the PythonInstance constructor calls (when they are not needed) to the IPythonType.CreateInstance

@CTrando CTrando requested a review from MikhailArkhipov Aug 31, 2019

CTrando added 5 commits Aug 31, 2019
@jakebailey
Copy link
Member

left a comment

LGTM, but I think we said we were going to wait to merge this until the persistence goes in.

@CTrando CTrando requested review from jakebailey and removed request for jakebailey Sep 3, 2019

@CTrando CTrando changed the base branch from master to db Sep 5, 2019

CTrando added 2 commits Sep 5, 2019

@MikhailArkhipov MikhailArkhipov changed the base branch from db to master Sep 16, 2019

@MikhailArkhipov MikhailArkhipov changed the base branch from master to db Sep 16, 2019

@MikhailArkhipov MikhailArkhipov merged commit 52e4beb into microsoft:db Sep 16, 2019

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.