Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we pass lookup options to expression evaluation #1604

Merged
merged 2 commits into from Oct 1, 2019

Conversation

@MikhailArkhipov
Copy link
Member

commented Sep 30, 2019

Fixes #1600

We must make sure lookup options for name resolution are passed since additional ClassMembers is passed in the class scope context so we can find class members without self..

@jakebailey

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

Fails AmbiguousOptionalParameterType, since the lookup options affect which A is found for the type hint.

@MikhailArkhipov MikhailArkhipov changed the title Make sure we pass lookup options to expression evaluation [WIP] Make sure we pass lookup options to expression evaluation Sep 30, 2019
@MikhailArkhipov MikhailArkhipov changed the title [WIP] Make sure we pass lookup options to expression evaluation Make sure we pass lookup options to expression evaluation Sep 30, 2019
@MikhailArkhipov MikhailArkhipov merged commit 5f5f31c into microsoft:master Oct 1, 2019
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
@MikhailArkhipov MikhailArkhipov deleted the MikhailArkhipov:b1600 branch Oct 1, 2019
@MikhailArkhipov

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2019

0.4.38+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.