Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid breaking the op stack when an unknown constant value is found #1650

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@jakebailey
Copy link
Member

commented Oct 8, 2019

Fixes #1640.

This is sort of a red herring, since the exception will actually be caught then the entire annotation converted to default, but explicitly pushing something onto the op stack when an unknown constant value is seen is better than destroying the entire annotation parse.

@jakebailey jakebailey merged commit 0ac9ea1 into microsoft:master Oct 8, 2019
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
@jakebailey jakebailey deleted the jakebailey:literal branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.