This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix PythonAnalyzerSession leak #866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leak has been happening because of the intermediate session has been marked completed, which could trigger a new session while the old one isn't completed. To avoid this, sessions don't reference one another in a form of linked list. Instead,
PythonAnalyzerholds reference to the currently-running session and updates the reference for the next session if new request comes before current session is completed.