Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.66-stable cherry pick #1025] Make RCTBundleManager's bundleURL a strong property #1027

Conversation

amgleitman
Copy link
Member

@amgleitman amgleitman commented Feb 16, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Cherry pick of the two commits in #1025.

@amgleitman amgleitman requested a review from alloy as a code owner Feb 16, 2022
@Saadnajmi
Copy link

Saadnajmi commented Feb 16, 2022

Nit: It's helpful if you put something like [0.66] - blah blah in the title so I know this is a cherry pick

@amgleitman amgleitman changed the title Make RCTBundleManager's bundleURL a strong property [0.66-stable cherry pick #1025] Make RCTBundleManager's bundleURL a strong property Feb 17, 2022
@amgleitman
Copy link
Member Author

amgleitman commented Feb 17, 2022

Nit: It's helpful if you put something like [0.66] - blah blah in the title so I know this is a cherry pick

Good point.

@amgleitman amgleitman merged commit 4bed389 into microsoft:0.66-stable Feb 17, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants