Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Required Libraries in ReactBridge's static init #910

Merged

Conversation

@msgharpu
Copy link

@msgharpu msgharpu commented Nov 23, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • [馃憤] I am making a change required for Microsoft usage of react-native

Summary

This change was there in RN63 and was removed in RN64 as an optimization.
However, this is a probable root cause for a regression. Hence adding the
patch again

Changelog

Modified the ReactBridge.java through a patch file in android-patches folder

This change was there in RN63 and was removed in RN64 as an optimization.
However, this is a probable root cause for a regression. Hence adding the
patch again
@msgharpu msgharpu requested a review from alloy as a code owner Nov 23, 2021
@msgharpu msgharpu requested a review from mganandraj Nov 23, 2021
@pull-bot
Copy link

@pull-bot pull-bot commented Nov 23, 2021

Warnings
鈿狅笍

Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
馃摉

馃搵 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

馃摉 馃搵 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 馃毇 dangerJS against 1ce3290

@harrieshin harrieshin merged commit ea8ae98 into microsoft:0.64-stable Nov 23, 2021
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants