Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Jun 23, 2020

Test Plan

  1. Apply the patch below (6f99beff7e was good last I checked)
  2. Run the usual install commands (i.e. yarn, pod install, etc.)
  3. Build the JS bundle, i.e. yarn build:android and yarn build:ios
  4. Build the app in Android Studio or Xcode
diff --git a/example/package.json b/example/package.json
index e16f729..f6aa424 100644
--- a/example/package.json
+++ b/example/package.json
@@ -16,10 +16,12 @@
   },
   "devDependencies": {
     "@babel/core": "^7.0.0",
+    "@react-native-community/cli": "^4.10.0",
+    "@react-native-community/cli-platform-android": "^4.10.0",
+    "@react-native-community/cli-platform-ios": "^4.10.0",
     "mkdirp": "^0.5.1",
-    "react": "16.9.0",
-    "react-native": "0.61.5",
-    "react-native-macos": "0.61.39",
+    "react": "16.13.1",
+    "react-native": "facebook/react-native#master",
     "react-native-test-app": "../"
   }
 }

@tido64 tido64 self-assigned this Jun 23, 2020
@tido64

This comment has been minimized.

@tido64 tido64 force-pushed the tido/rn-master branch 2 times, most recently from 0ba7f54 to 2c89111 Compare June 23, 2020 16:41
@tido64

This comment has been minimized.

@tido64 tido64 force-pushed the tido/rn-63 branch 3 times, most recently from 09dc526 to c18aa7d Compare June 23, 2020 22:21
Base automatically changed from tido/rn-63 to master June 24, 2020 15:40
@tido64 tido64 marked this pull request as ready for review June 24, 2020 17:51
Copy link
Member

@sweggersen sweggersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done solution for Android 👏 LGTM

@tido64 tido64 merged commit 062b83e into master Jun 24, 2020
@tido64 tido64 deleted the tido/rn-master branch June 24, 2020 18:01
@tido64
Copy link
Member Author

tido64 commented Jun 24, 2020

🎉 This PR is included in version 0.1.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for building React Native from source

3 participants