Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Jun 23, 2020

Test Plan

  1. Bump to 0.62
    diff --git a/example/package.json b/example/package.json
    index f245bf9..80824e0 100644
    --- a/example/package.json
    +++ b/example/package.json
    @@ -17,9 +17,8 @@
       "devDependencies": {
         "@babel/core": "^7.0.0",
         "mkdirp": "^0.5.1",
    -    "react": "16.9.0",
    -    "react-native": "0.61.5",
    -    "react-native-macos": "0.61.39",
    +    "react": "16.11.0",
    +    "react-native": "0.62.2",
         "react-native-test-app": "../"
       }
     }
  2. Run yarn && pod install --project-directory=ios
  3. Observe that Flipper gets included
  4. Disable Flipper
    diff --git a/example/ios/Podfile b/example/ios/Podfile
    index 59f8153..953899c 100644
    --- a/example/ios/Podfile
    +++ b/example/ios/Podfile
    @@ -2,6 +2,7 @@ require_relative '../node_modules/react-native-test-app/test_app.rb'
    
     workspace 'Example.xcworkspace'
    
    +use_flipper!(false)
     use_test_app! do |target|
       target.tests do
         pod 'Example-Tests', :path => '..'
  5. pod install --project-directory=ios
  6. Observe that Flipper is removed

@tido64 tido64 added the platform: iOS This affects iOS label Jun 23, 2020
@tido64 tido64 requested a review from alloy June 23, 2020 21:42
@tido64 tido64 self-assigned this Jun 23, 2020
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Might be good to extract it to a method with a self documenting name at some point.

@tido64
Copy link
Member Author

tido64 commented Jun 24, 2020

Looks good +1 Might be good to extract it to a method with a self documenting name at some point.

Agreed. We should be adding tests as well. Not been very good with that either.

@tido64 tido64 merged commit ff89d20 into master Jun 24, 2020
@tido64 tido64 deleted the tido/fix-ios-flipper branch June 24, 2020 08:39
@tido64
Copy link
Member Author

tido64 commented Jun 24, 2020

🎉 This PR is included in version 0.1.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants