Add System.Messaging sources #141
Conversation
@terrajobst can you please merge it? |
internal sealed class SecurityContextHandle : SafeHandleZeroOrMinusOneIsInvalid | ||
{ | ||
|
||
internal SecurityContextHandle(IntPtr existingHandle) |
KalleOlaviNiemitalo
Jun 22, 2020
A note to anyone intending to reuse this code.
System.Messaging.MessageQueue.GetSecurityContext() always throws MissingMethodException because SecurityContextHandle lacks a parameterless (perhaps private) constructor that Platform Invoke would call here:
referencesource/System.Messaging/System/Messaging/Interop/NativeMethods.cs
Lines 320 to 334
in
08847a3
I don't expect the bug to be fixed in .NET Framework (reported to connect.microsoft.com in 2010) or in Reference Source, but perhaps it can be fixed in the .NET Core port.
A note to anyone intending to reuse this code.
System.Messaging.MessageQueue.GetSecurityContext() always throws MissingMethodException because SecurityContextHandle lacks a parameterless (perhaps private) constructor that Platform Invoke would call here:
referencesource/System.Messaging/System/Messaging/Interop/NativeMethods.cs
Lines 320 to 334 in 08847a3
I don't expect the bug to be fixed in .NET Framework (reported to connect.microsoft.com in 2010) or in Reference Source, but perhaps it can be fixed in the .NET Core port.
@terrajobst can we merge it please? |
@karelz is there a code owner that can sign off here, for the sake of process? I have merge powers and can do that. |
Can we also tag the person who originally requested this, so they can confirm everything's here? |
@danmosemsft I am not sure if you mean someone internal to MSFT, but I am the one who sent the original email after @karelz asked me to in dotnet/runtime#16409 (comment) , and everything I need is in the commit. |
@danmosemsft code owners in .NET Framework are tagged above: #141 (comment) |
Done! Hope this is what you need @weloytty and apologies for the time it took. |
Nice! cc @mconnew fyi. |
There's going to be some features in this which are broken. For example, you can use transactions with MSMQ but the implementation of System.Transactions in .NET Core doesn't work with MSDTC so that part of System.Messaging won't work. I'm not super familiar with the code base or even api so I'm not volunteering, but someone should go through the features supported by the api and work out what does and doesn't work and throw PlatformNotSupportedException on things which don't work instead of having everyone who consumes this api try and work out why their app isn't working as expected. |
Code for System.Messaging