Accessibility Fix for Metric Checkboxes #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advitya17
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
imatiach-msft
approved these changes
Jan 8, 2024
hawestra
approved these changes
Jan 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes a single change to improve the accessibility of the
MetricConfigurationcomponent in theModelAssessmentDashboardmodule. The change adds a new propcheckButtonAriaLabelto provide an aria label for the check button.libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/MetricConfigurationFlyout.tsx: Added a new propcheckButtonAriaLabelto theMetricConfigurationcomponent to improve accessibility.Before change:
After change:
Checklist