Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class View Search Case Fix #2498

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Class View Search Case Fix #2498

merged 2 commits into from
Jan 23, 2024

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Jan 19, 2024

Before:
image

With fix:
image

This pull request includes updates to various files to ensure proper lowercase conversion using the appropriate locale. The most important changes include updating the toLowerCase() method to toLocaleLowerCase() in Insights.tsx, getFilteredData.ts, and ModelAssessmentDashboard/Controls/ModelOverview/CohortStatsHeatmap.tsx.

Main changes:

GitHub Chat Prompt

image

Response snippet:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@Advitya17 Advitya17 merged commit 01cb9d5 into main Jan 23, 2024
81 checks passed
@Advitya17 Advitya17 deleted the agemawat/class_search branch January 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants