HdfConverter: map status to SARIF kind/level/rank correctly (#2695) - #2696
Merged
Michael C. Fanning (michaelcfanning) merged 1 commit intoJul 24, 2023
Merged
Conversation
Craig Andrews (candrews)
commented
Jul 24, 2023
Craig Andrews (candrews)
commented
Collaborator
- rank should only be output when kind=fail
- level should only be output when kind=fail
- handle kind values of passed, faild, error, and skipped
…t#2695) * rank should only be output when kind=fail * level should only be output when kind=fail * handle kind values of passed, faild, error, and skipped Signed-off-by: Craig Andrews <candrews@integralblue.com>
Craig Andrews (candrews)
requested review from
Chris Meyer (EasyRhinoMSFT),
cfaucon,
marmegh and
Michael C. Fanning (michaelcfanning)
as code owners
July 24, 2023 19:09
Contributor
|
Merged. I'll drop in a release note in a subsequent change. Do you need a NuGet release? |
Collaborator
Author
I'm hoping to get an MR in for #2694 very soon (:crossed_fingers: today), after that, a release would be amazing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.