Python: Milvus memory connector #1941

filip-halt · 2023-07-11T04:56:04Z

This change brings in Milvus to the semantic kernel connectors.

filip-halt · 2023-07-11T04:56:46Z

@fzliu

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

filip-halt · 2023-07-11T21:22:05Z

@microsoft-github-policy-service agree company="Zilliz"

tawalke · 2023-07-11T22:11:03Z

@filip-halt Following up on your offline note. Looks like it's already assigned for review.

@alexchaomander for visibility.

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py

…store.py

…into milvus

python/tests/integration/connectors/memory/test_milvus.py

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

awharrison-28 · 2023-07-17T17:26:12Z

Hi @filip-halt the code looks good, but I'm hitting errors with the integration tests where the default server is refusing to start due to communication timeouts. I'm seeing the issue standalone as well. I'm not sure if it's just a me problem, or if there's a bug with the default server - this wasn't an issue for me last week. Are you able to run these locally today?

fzliu · 2023-07-17T19:52:57Z

Hi @filip-halt the code looks good, but I'm hitting errors with the integration tests where the default server is refusing to start due to communication timeouts. I'm seeing the issue standalone as well. I'm not sure if it's just a me problem, or if there's a bug with the default server - this wasn't an issue for me last week. Are you able to run these locally today?

What kind of errors are you hitting? (PR seem to be working for me)

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py

…store.py

filip-halt · 2023-07-18T16:52:32Z

I would also like to know what kind of error is being seen? I just tested locally and everything seems to be running fine. Did the error happen on a first runthrough or after a few?

awharrison-28 · 2023-07-18T18:00:27Z

I would also like to know what kind of error is being seen? I just tested locally and everything seems to be running fine. Did the error happen on a first runthrough or after a few?

Hmmm my machine might be in a bad state. I'll have someone else test locally.

I don't believe I had the errors on the first runthrough, but definitely every run after that.

all from the default_server.start() call.

filip-halt · 2023-07-18T21:01:05Z

It might be corruption of the persisted data. If the system crashes before the cleanup of the fixture there might be problems in future runs. Let me take a look.

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

filip-halt · 2023-07-18T21:11:13Z

@awharrison-28 I put the call to preclean the service before running. This might help with your errors.

awharrison-28

Looks like I had an orphan process hogging the default server. Restarting my machine did the trick :)

This change brings in Milvus to the semantic kernel connectors. --------- Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>

roji

@awharrison-28 hey, I'm working on a .NET version of the Milvus connector - see #2694. Below are some questions that came up while implementing this, can you give these a quick look? It would be great if we can more or less align across to connectors to ensure a uniform experience etc.

roji · 2023-09-02T20:29:02Z

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py

+
+        # Clean up results, filter and get ids for fetch
+        for x in results:
+            if min_relevance_score is not None and x["distance"] < min_relevance_score:


@awharrison-28 unless I'm mistaken, the interaction between limit and the minimal relevance score looks like it yields buggy behavior: since limit is sent to Milvus but not the relevance score, Milvus only returns the top X, which may then get filtered client-side to return less than X to the user. In other words, there may be additional matching results which meet the relevance score, but which aren't returned by Milvus because of the limit.

I indeed cannot see a way to send the minimum relevance score to Milvus for processing server-side, so this behavior may be an acceptable compromise - just wanted to check that you're aware of it etc.

Thank you for raising the issue here, I was not aware.

Update: the recently-released Milvus 2.3 (release notes) has a new feature - range search - which allows doing this. This would be considerably better than the current client-side implementation.

roji · 2023-09-02T20:32:49Z

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py

+            )[0]
+            return results, distance_metric
+        except Exception as e:
+            self._logger.debug(f"Search failed with IP, testing L2: {e}")


@awharrison-28 rather than catching and retrying the other similarity type, does it make sense to simply allow the user to pass the similarity type when invoking get_nearest_matches_async? After all, the only way to get an index with a similarity type other than the default IP is to explicitly pass L2 to create_collection_async.

Another approach I've seen in other SK memory connectors is to accept such settings in the MemoryStore constructor, and have it affect both create_collection and get_nearest_matches_async. This has the advantage of allowing users to work purely with the MemoryStoreBase abstraction without non-standard arguments to the various functions (only when constructing the memory store, which is non-standard anyway).

roji · 2023-09-02T21:13:41Z

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py

+        additional_metadata=milvus_dict.get("additional_metadata", None),
+        embedding=embedding,
+        key=milvus_dict.get("key", None),
+        timestamp=milvus_dict.get("timestamp", None),


What representation actually gets saved to Milvus, given that it doesn't seem to support any sort of date/time type?

my understanding is that timestamp resolves to a string

@awharrison-28

This is a working version of an SK memory store connector for Milvus, for .NET. It is built on top of the recently-released [Milvus.Client](https://www.nuget.org/packages/Milvus.Client) (experimental, in preview), which uses gRPC to communicate with Milvus. There are some minor outstanding issues which are also relevant for the Python connector (merged via #1941), I'll sync with @awharrison-28 to align on these. But this should be more or less ready to merge, we can iterate on the remaining stuff. Closes #2316 /cc @stephentoub @awharrison-28 @luisquintanilla @MarianaGG @tawalke @ajcvickers --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Lee Miller <lemiller@microsoft.com>

@awharrison-28

This is a working version of an SK memory store connector for Milvus, for .NET. It is built on top of the recently-released [Milvus.Client](https://www.nuget.org/packages/Milvus.Client) (experimental, in preview), which uses gRPC to communicate with Milvus. There are some minor outstanding issues which are also relevant for the Python connector (merged via microsoft#1941), I'll sync with @awharrison-28 to align on these. But this should be more or less ready to merge, we can iterate on the remaining stuff. Closes microsoft#2316 /cc @stephentoub @awharrison-28 @luisquintanilla @MarianaGG @tawalke @ajcvickers --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com> Co-authored-by: Lee Miller <lemiller@microsoft.com>

filip-halt requested a review from a team as a code owner July 11, 2023 04:56

shawncal added python Pull requests for the Python Semantic Kernel memory connector labels Jul 11, 2023

shawncal changed the title ~~[WIP] Milvus memory connector~~ Python: [WIP] Milvus memory connector Jul 11, 2023

shawncal assigned awharrison-28 Jul 11, 2023

Adding Milvus memory connector

6164212

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

filip-halt force-pushed the milvus branch from 3f03eff to 6164212 Compare July 11, 2023 21:21

filip-halt changed the title ~~Python: [WIP] Milvus memory connector~~ Python: Milvus memory connector Jul 14, 2023

awharrison-28 and others added 2 commits July 14, 2023 11:08

merge with main, resolve conflicts

efa107f

Merge branch 'main' into milvus

2e32726

awharrison-28 reviewed Jul 14, 2023

View reviewed changes

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py Outdated Show resolved Hide resolved

awharrison-28 and others added 3 commits July 14, 2023 12:27

Update python/semantic_kernel/connectors/memory/milvus/milvus_memory_…

d2bde85

…store.py

pre-commit checks

3824741

Merge branch 'milvus' of https://github.com/filip-halt/semantic-kernel …

75ccbbe

…into milvus

awharrison-28 requested changes Jul 14, 2023

View reviewed changes

python/tests/integration/connectors/memory/test_milvus.py Show resolved Hide resolved

awharrison-28 added the PR: feedback to address Waiting for PR owner to address comments/questions label Jul 14, 2023

Updating Fixture for Milvus

e7c65b4

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

awharrison-28 mentioned this pull request Jul 17, 2023

Python: Milvus Memory Store #2023

Closed

updated lock file and resolved conflicts

afd7306

awharrison-28 and others added 2 commits July 17, 2023 10:39

Merge branch 'main' into milvus

7ee7c16

pre-commit checks

0c5f288

awharrison-28 reviewed Jul 18, 2023

View reviewed changes

python/semantic_kernel/connectors/memory/milvus/milvus_memory_store.py Outdated Show resolved Hide resolved

Update python/semantic_kernel/connectors/memory/milvus/milvus_memory_…

3bb4af4

…store.py

awharrison-28 requested a review from mkarle July 18, 2023 18:00

awharrison-28 and others added 2 commits July 18, 2023 14:03

updated poetry lock

634e89a

preclean test milvus

6916b66

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

awharrison-28 approved these changes Jul 18, 2023

View reviewed changes

awharrison-28 enabled auto-merge July 18, 2023 22:00

awharrison-28 added this pull request to the merge queue Jul 18, 2023

Merged via the queue into microsoft:main with commit e50ac0b Jul 18, 2023
20 checks passed

roji mentioned this pull request Sep 2, 2023

.Net: Milvus memory store connector for .NET #2694

Merged

roji reviewed Sep 2, 2023

View reviewed changes

roji mentioned this pull request Sep 20, 2023

Python: Milvus: consider using static rather than dynamic fields for the Semantic Kernel metadata #2901

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python: Milvus memory connector #1941

Python: Milvus memory connector #1941

filip-halt commented Jul 11, 2023 •

edited

Loading

filip-halt commented Jul 11, 2023

filip-halt commented Jul 11, 2023

tawalke commented Jul 11, 2023

awharrison-28 commented Jul 17, 2023

fzliu commented Jul 17, 2023 •

edited

Loading

filip-halt commented Jul 18, 2023

awharrison-28 commented Jul 18, 2023

filip-halt commented Jul 18, 2023

filip-halt commented Jul 18, 2023

awharrison-28 left a comment

roji left a comment

roji Sep 2, 2023

awharrison-28 Sep 5, 2023

roji Sep 6, 2023

roji Sep 2, 2023

roji Sep 2, 2023

awharrison-28 Sep 5, 2023

Python: Milvus memory connector #1941

Python: Milvus memory connector #1941

Conversation

filip-halt commented Jul 11, 2023 • edited Loading

filip-halt commented Jul 11, 2023

filip-halt commented Jul 11, 2023

tawalke commented Jul 11, 2023

awharrison-28 commented Jul 17, 2023

fzliu commented Jul 17, 2023 • edited Loading

filip-halt commented Jul 18, 2023

awharrison-28 commented Jul 18, 2023

filip-halt commented Jul 18, 2023

filip-halt commented Jul 18, 2023

awharrison-28 left a comment

Choose a reason for hiding this comment

roji left a comment

Choose a reason for hiding this comment

roji Sep 2, 2023

Choose a reason for hiding this comment

awharrison-28 Sep 5, 2023

Choose a reason for hiding this comment

roji Sep 6, 2023

Choose a reason for hiding this comment

roji Sep 2, 2023

Choose a reason for hiding this comment

roji Sep 2, 2023

Choose a reason for hiding this comment

awharrison-28 Sep 5, 2023

Choose a reason for hiding this comment

filip-halt commented Jul 11, 2023 •

edited

Loading

fzliu commented Jul 17, 2023 •

edited

Loading