.Net: Fixing Example48_GroundednessChecks + Tuning Variable usage in Handlebars Planner #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
teresaqhoang
changed the title
alliscode
approved these changes
Dec 7, 2023
TaoChenOSU
approved these changes
Dec 7, 2023
dotnet/samples/KernelSyntaxExamples/Example48_GroundednessChecks.cs
Outdated
Show resolved
Hide resolved
crickman
approved these changes
Dec 7, 2023
TaoChenOSU
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses bug #3837, where the plan didn't produce expected Groundedness result.
Fix was to add the GroundingText to the ask (used as the Goal in the planner).
Description
PR also contains small fixes to label parameters in relevant semantic functions as required + some tuning of the CreatePlan prompt to emphasize proper variable usage.
Contribution Checklist