From ee41a0d98d7f4469a4a20a999e1b624efd00c758 Mon Sep 17 00:00:00 2001 From: Matthew Parkinson Date: Wed, 10 Aug 2022 11:50:06 +0100 Subject: [PATCH 1/3] Update BUILDING.md --- docs/BUILDING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/BUILDING.md b/docs/BUILDING.md index 849a4c839..a33d3d7a9 100644 --- a/docs/BUILDING.md +++ b/docs/BUILDING.md @@ -5,13 +5,14 @@ snmalloc uses a CMake build system and can be built on many platforms. # Building on Windows -The Windows build currently depends on Visual Studio 2017. +The Windows build currently depends on at least Visual Studio. +Both the 2019 and 2022 are regularly tested. To build with Visual Studio: ``` mkdir build cd build -cmake -G "Visual Studio 15 2017 Win64" .. +cmake -G "Visual Studio 15 2019 Win64" .. cmake --build . --config Debug cmake --build . --config Release cmake --build . --config RelWithDebInfo From 62eb360738697baec4a98162864c88697ac9d469 Mon Sep 17 00:00:00 2001 From: Matthew Parkinson Date: Wed, 10 Aug 2022 12:05:36 +0100 Subject: [PATCH 2/3] Update docs/BUILDING.md Co-authored-by: David Chisnall --- docs/BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/BUILDING.md b/docs/BUILDING.md index a33d3d7a9..675caf918 100644 --- a/docs/BUILDING.md +++ b/docs/BUILDING.md @@ -5,7 +5,7 @@ snmalloc uses a CMake build system and can be built on many platforms. # Building on Windows -The Windows build currently depends on at least Visual Studio. +The Windows build currently depends on at least Visual Studio 2019. Both the 2019 and 2022 are regularly tested. To build with Visual Studio: From 3606a184329b58a850a1f555d4d4d3fecbb3e2ad Mon Sep 17 00:00:00 2001 From: Matthew Parkinson Date: Wed, 10 Aug 2022 12:07:07 +0100 Subject: [PATCH 3/3] Update docs/BUILDING.md --- docs/BUILDING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/BUILDING.md b/docs/BUILDING.md index 675caf918..2dd3ed04b 100644 --- a/docs/BUILDING.md +++ b/docs/BUILDING.md @@ -6,7 +6,8 @@ snmalloc uses a CMake build system and can be built on many platforms. # Building on Windows The Windows build currently depends on at least Visual Studio 2019. -Both the 2019 and 2022 are regularly tested. +Both Visual Studio 2019 and 2022 are regularly tested in CI. +Additionally, `clang-cl` is also supported and tested by CI. To build with Visual Studio: ```