From 0da307f15d89c78b619ec3fa4f006f6274bf8825 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 9 Jun 2017 08:59:02 +0900 Subject: [PATCH 1/5] gofmt --- samples/tutorials/go/columnstore.go | 95 ++++++------- samples/tutorials/go/connect.go | 68 +++++----- samples/tutorials/go/crud.go | 201 ++++++++++++++-------------- samples/tutorials/go/orm.go | 197 +++++++++++++-------------- 4 files changed, 285 insertions(+), 276 deletions(-) diff --git a/samples/tutorials/go/columnstore.go b/samples/tutorials/go/columnstore.go index a9994798e9..bf8883f453 100644 --- a/samples/tutorials/go/columnstore.go +++ b/samples/tutorials/go/columnstore.go @@ -1,46 +1,49 @@ -package main - -import _ "github.com/denisenkom/go-mssqldb" -import "database/sql" -import "log" -import "fmt" -import "time" - -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" -var database = "SampleDB" - -// Delete an employee from database -func ExecuteAggregateStatement(db *sql.DB) { - result, err := db.Prepare("SELECT SUM(Price) as sum FROM Table_with_5M_rows") - if err != nil { - fmt.Println("Error preparing query: " + err.Error()) - } - - row := result.QueryRow() - var sum string - err = row.Scan(&sum) - fmt.Printf("Sum: %s\n", sum) -} - -func main() { - // Connect to database - connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d;database=%s;", - server, user, password, port, database) - conn, err := sql.Open("mssql", connString) - if err != nil { - log.Fatal("Open connection failed:", err.Error()) - } - fmt.Printf("Connected!\n") - defer conn.Close() - - t1 := time.Now() - fmt.Printf("Start time: %s\n", t1) - - ExecuteAggregateStatement(conn) - - t2 := time.Since(t1) - fmt.Printf("The query took: %s\n", t2) -} \ No newline at end of file +package main + +import ( + "database/sql" + "fmt" + "log" + "time" + + _ "github.com/denisenkom/go-mssqldb" +) + +var server = "localhost" +var port = 1433 +var user = "sa" +var password = "your_password" +var database = "SampleDB" + +// Delete an employee from database +func ExecuteAggregateStatement(db *sql.DB) { + result, err := db.Prepare("SELECT SUM(Price) as sum FROM Table_with_5M_rows") + if err != nil { + fmt.Println("Error preparing query: " + err.Error()) + } + + row := result.QueryRow() + var sum string + err = row.Scan(&sum) + fmt.Printf("Sum: %s\n", sum) +} + +func main() { + // Connect to database + connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d;database=%s;", + server, user, password, port, database) + conn, err := sql.Open("mssql", connString) + if err != nil { + log.Fatal("Open connection failed:", err.Error()) + } + fmt.Printf("Connected!\n") + defer conn.Close() + + t1 := time.Now() + fmt.Printf("Start time: %s\n", t1) + + ExecuteAggregateStatement(conn) + + t2 := time.Since(t1) + fmt.Printf("The query took: %s\n", t2) +} diff --git a/samples/tutorials/go/connect.go b/samples/tutorials/go/connect.go index da320b1a1a..7f76c9889e 100644 --- a/samples/tutorials/go/connect.go +++ b/samples/tutorials/go/connect.go @@ -1,33 +1,35 @@ -package main - -import _ "github.com/denisenkom/go-mssqldb" -import "database/sql" -import "log" -import "fmt" - - -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" - -func main() { - connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d", - server, user, password, port) - - conn, err := sql.Open("mssql", connString) - if err != nil { - log.Fatal("Open connection failed:", err.Error()) - } - fmt.Printf("Connected!\n") - defer conn.Close() - stmt, err := conn.Prepare("select @@version") - row := stmt.QueryRow() - var result string - - err = row.Scan(&result) - if err != nil { - log.Fatal("Scan failed:", err.Error()) - } - fmt.Printf("%s\n", result) -} \ No newline at end of file +package main + +import ( + "database/sql" + "fmt" + "log" + + _ "github.com/denisenkom/go-mssqldb" +) + +var server = "localhost" +var port = 1433 +var user = "sa" +var password = "your_password" + +func main() { + connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d", + server, user, password, port) + + conn, err := sql.Open("mssql", connString) + if err != nil { + log.Fatal("Open connection failed:", err.Error()) + } + fmt.Printf("Connected!\n") + defer conn.Close() + stmt, err := conn.Prepare("select @@version") + row := stmt.QueryRow() + var result string + + err = row.Scan(&result) + if err != nil { + log.Fatal("Scan failed:", err.Error()) + } + fmt.Printf("%s\n", result) +} diff --git a/samples/tutorials/go/crud.go b/samples/tutorials/go/crud.go index efb18c9c9f..ca5637bdd8 100644 --- a/samples/tutorials/go/crud.go +++ b/samples/tutorials/go/crud.go @@ -1,99 +1,102 @@ -package main - -import _ "github.com/denisenkom/go-mssqldb" -import "database/sql" -import "log" -import "fmt" - -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" -var database = "SampleDB" - -// Create an employee -func CreateEmployee(db *sql.DB, name string, location string) (int64, error) { - tsql := fmt.Sprintf("INSERT INTO TestSchema.Employees (Name, Location) VALUES ('%s','%s');", - name, location) - result, err := db.Exec(tsql) - if err != nil { - fmt.Println("Error inserting new row: " + err.Error()) - return -1, err - } - return result.LastInsertId() -} - -// Read all employees -func ReadEmployees(db *sql.DB) (int, error) { - tsql := fmt.Sprintf("SELECT Id, Name, Location FROM TestSchema.Employees;") - rows, err := db.Query(tsql) - if err != nil { - fmt.Println("Error reading rows: " + err.Error()) - return -1, err - } - defer rows.Close() - var count int = 0 - for rows.Next(){ - var name, location string - var id int - err := rows.Scan(&id, &name, &location) - if err != nil { - fmt.Println("Error reading rows: " + err.Error()) - return -1, err - } - fmt.Printf("ID: %d, Name: %s, Location: %s\n", id, name, location) - count++ - } - return count, nil -} - -// Update an employee's information -func UpdateEmployee(db *sql.DB, name string, location string) (int64, error) { - tsql := fmt.Sprintf("UPDATE TestSchema.Employees SET Location = '%s' WHERE Name= '%s'", - location, name) - result, err := db.Exec(tsql) - if err != nil { - fmt.Println("Error updating row: " + err.Error()) - return -1, err - } - return result.LastInsertId() -} - -// Delete an employee from database -func DeleteEmployee(db *sql.DB, name string) (int64, error) { - tsql := fmt.Sprintf("DELETE FROM TestSchema.Employees WHERE Name='%s';", name) - result, err := db.Exec(tsql) - if err != nil { - fmt.Println("Error deleting row: " + err.Error()) - return -1, err - } - return result.RowsAffected() -} - -func main() { - // Connect to database - connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d;database=%s;", - server, user, password, port, database) - conn, err := sql.Open("mssql", connString) - if err != nil { - log.Fatal("Open connection failed:", err.Error()) - } - fmt.Printf("Connected!\n") - defer conn.Close() - - // Create employee - createId, err := CreateEmployee(conn, "Jake", "United States") - fmt.Printf("Inserted ID: %d successfully.\n", createId) - - // Read employees - count, err := ReadEmployees(conn) - fmt.Printf("Read %d rows successfully.\n", count) - - // Update from database - updateId, err := UpdateEmployee(conn, "Jake", "Poland") - fmt.Printf("Updated row with ID: %d successfully.\n", updateId) - - // Delete from database - rows, err := DeleteEmployee(conn, "Jake") - fmt.Printf("Deleted %d rows successfully.\n", rows) -} \ No newline at end of file +package main + +import ( + "database/sql" + "fmt" + "log" + + _ "github.com/denisenkom/go-mssqldb" +) + +var server = "localhost" +var port = 1433 +var user = "sa" +var password = "your_password" +var database = "SampleDB" + +// Create an employee +func CreateEmployee(db *sql.DB, name string, location string) (int64, error) { + tsql := fmt.Sprintf("INSERT INTO TestSchema.Employees (Name, Location) VALUES ('%s','%s');", + name, location) + result, err := db.Exec(tsql) + if err != nil { + fmt.Println("Error inserting new row: " + err.Error()) + return -1, err + } + return result.LastInsertId() +} + +// Read all employees +func ReadEmployees(db *sql.DB) (int, error) { + tsql := fmt.Sprintf("SELECT Id, Name, Location FROM TestSchema.Employees;") + rows, err := db.Query(tsql) + if err != nil { + fmt.Println("Error reading rows: " + err.Error()) + return -1, err + } + defer rows.Close() + var count int = 0 + for rows.Next() { + var name, location string + var id int + err := rows.Scan(&id, &name, &location) + if err != nil { + fmt.Println("Error reading rows: " + err.Error()) + return -1, err + } + fmt.Printf("ID: %d, Name: %s, Location: %s\n", id, name, location) + count++ + } + return count, nil +} + +// Update an employee's information +func UpdateEmployee(db *sql.DB, name string, location string) (int64, error) { + tsql := fmt.Sprintf("UPDATE TestSchema.Employees SET Location = '%s' WHERE Name= '%s'", + location, name) + result, err := db.Exec(tsql) + if err != nil { + fmt.Println("Error updating row: " + err.Error()) + return -1, err + } + return result.LastInsertId() +} + +// Delete an employee from database +func DeleteEmployee(db *sql.DB, name string) (int64, error) { + tsql := fmt.Sprintf("DELETE FROM TestSchema.Employees WHERE Name='%s';", name) + result, err := db.Exec(tsql) + if err != nil { + fmt.Println("Error deleting row: " + err.Error()) + return -1, err + } + return result.RowsAffected() +} + +func main() { + // Connect to database + connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d;database=%s;", + server, user, password, port, database) + conn, err := sql.Open("mssql", connString) + if err != nil { + log.Fatal("Open connection failed:", err.Error()) + } + fmt.Printf("Connected!\n") + defer conn.Close() + + // Create employee + createId, err := CreateEmployee(conn, "Jake", "United States") + fmt.Printf("Inserted ID: %d successfully.\n", createId) + + // Read employees + count, err := ReadEmployees(conn) + fmt.Printf("Read %d rows successfully.\n", count) + + // Update from database + updateId, err := UpdateEmployee(conn, "Jake", "Poland") + fmt.Printf("Updated row with ID: %d successfully.\n", updateId) + + // Delete from database + rows, err := DeleteEmployee(conn, "Jake") + fmt.Printf("Deleted %d rows successfully.\n", rows) +} diff --git a/samples/tutorials/go/orm.go b/samples/tutorials/go/orm.go index c68b8ae468..61ed4349b6 100644 --- a/samples/tutorials/go/orm.go +++ b/samples/tutorials/go/orm.go @@ -1,98 +1,99 @@ -package main - -import ( - "fmt" - "github.com/jinzhu/gorm" - _ "github.com/jinzhu/gorm/dialects/mssql" -) - -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" -var database = "SampleDB" - -type User struct { - gorm.Model - FirstName string - LastName string -} - -type Task struct { - gorm.Model - Title string - DueDate string - IsComplete bool - UserID uint -} - -func ReadAllTasks(db *gorm.DB){ - var users []User - var tasks []Task - db.Find(&users) - - for _, user := range users{ - db.Model(&user).Related(&tasks) - fmt.Printf("%s %s's tasks:\n", user.FirstName, user.LastName) - for _, task := range tasks { - fmt.Printf("Title: %s\nDueDate: %s\nIsComplete:%t\n\n", - task.Title, task.DueDate, task.IsComplete) - } - } -} - -func UpdateSomeonesTask(db *gorm.DB, userId int){ - var task Task - db.Where("user_id = ?", userId).First(&task).Update("Title", "Buy donuts for Luis") - fmt.Printf("Title: %s\nDueDate: %s\nIsComplete:%t\n\n", - task.Title, task.DueDate, task.IsComplete) -} - -func DeleteSomeonesTasks(db *gorm.DB, userId int){ - db.Where("user_id = ?", userId).Delete(&Task{}) - fmt.Printf("Deleted all tasks for user %d", userId) -} - -func main() { - connectionString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d;database=%s", - server, user, password, port, database) - db, err := gorm.Open("mssql", connectionString) - - if err != nil { - panic("failed to connect database") - } - gorm.DefaultCallback.Create().Remove("mssql:set_identity_insert") - defer db.Close() - - fmt.Println("Migrating models...") - db.AutoMigrate(&User{}) - db.AutoMigrate(&Task{}) - - // Create awesome Users - fmt.Println("Creating awesome users...") - db.Create(&User{FirstName: "Andrea", LastName: "Lam"}) //UserID: 1 - db.Create(&User{FirstName: "Meet", LastName: "Bhagdev"}) //UserID: 2 - db.Create(&User{FirstName: "Luis", LastName: "Bosquez"}) //UserID: 3 - - // Create appropriate Tasks for each user - fmt.Println("Creating new appropriate tasks...") - db.Create(&Task{ - Title: "Do laundry", DueDate: "2017-03-30", IsComplete: false, UserID: 1}) - db.Create(&Task{ - Title: "Mow the lawn", DueDate: "2017-03-30", IsComplete: false, UserID: 2}) - db.Create(&Task{ - Title: "Do more laundry", DueDate: "2017-03-30", IsComplete: false, UserID: 3}) - db.Create(&Task{ - Title: "Watch TV", DueDate: "2017-03-30", IsComplete: false, UserID: 3}) - - // Read - fmt.Println("Reading all the tasks...") - ReadAllTasks(db) - - // Update - update Task title to something more appropriate - fmt.Println("Updating Andrea's task...") - UpdateSomeonesTask(db, 1) - - // Delete - delete Luis's task - DeleteSomeonesTasks(db, 3) -} \ No newline at end of file +package main + +import ( + "fmt" + + "github.com/jinzhu/gorm" + _ "github.com/jinzhu/gorm/dialects/mssql" +) + +var server = "localhost" +var port = 1433 +var user = "sa" +var password = "your_password" +var database = "SampleDB" + +type User struct { + gorm.Model + FirstName string + LastName string +} + +type Task struct { + gorm.Model + Title string + DueDate string + IsComplete bool + UserID uint +} + +func ReadAllTasks(db *gorm.DB) { + var users []User + var tasks []Task + db.Find(&users) + + for _, user := range users { + db.Model(&user).Related(&tasks) + fmt.Printf("%s %s's tasks:\n", user.FirstName, user.LastName) + for _, task := range tasks { + fmt.Printf("Title: %s\nDueDate: %s\nIsComplete:%t\n\n", + task.Title, task.DueDate, task.IsComplete) + } + } +} + +func UpdateSomeonesTask(db *gorm.DB, userId int) { + var task Task + db.Where("user_id = ?", userId).First(&task).Update("Title", "Buy donuts for Luis") + fmt.Printf("Title: %s\nDueDate: %s\nIsComplete:%t\n\n", + task.Title, task.DueDate, task.IsComplete) +} + +func DeleteSomeonesTasks(db *gorm.DB, userId int) { + db.Where("user_id = ?", userId).Delete(&Task{}) + fmt.Printf("Deleted all tasks for user %d", userId) +} + +func main() { + connectionString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d;database=%s", + server, user, password, port, database) + db, err := gorm.Open("mssql", connectionString) + + if err != nil { + panic("failed to connect database") + } + gorm.DefaultCallback.Create().Remove("mssql:set_identity_insert") + defer db.Close() + + fmt.Println("Migrating models...") + db.AutoMigrate(&User{}) + db.AutoMigrate(&Task{}) + + // Create awesome Users + fmt.Println("Creating awesome users...") + db.Create(&User{FirstName: "Andrea", LastName: "Lam"}) //UserID: 1 + db.Create(&User{FirstName: "Meet", LastName: "Bhagdev"}) //UserID: 2 + db.Create(&User{FirstName: "Luis", LastName: "Bosquez"}) //UserID: 3 + + // Create appropriate Tasks for each user + fmt.Println("Creating new appropriate tasks...") + db.Create(&Task{ + Title: "Do laundry", DueDate: "2017-03-30", IsComplete: false, UserID: 1}) + db.Create(&Task{ + Title: "Mow the lawn", DueDate: "2017-03-30", IsComplete: false, UserID: 2}) + db.Create(&Task{ + Title: "Do more laundry", DueDate: "2017-03-30", IsComplete: false, UserID: 3}) + db.Create(&Task{ + Title: "Watch TV", DueDate: "2017-03-30", IsComplete: false, UserID: 3}) + + // Read + fmt.Println("Reading all the tasks...") + ReadAllTasks(db) + + // Update - update Task title to something more appropriate + fmt.Println("Updating Andrea's task...") + UpdateSomeonesTask(db, 1) + + // Delete - delete Luis's task + DeleteSomeonesTasks(db, 3) +} From 5d10070d3f6a67abf2e3004528b44b52e3f58add Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 9 Jun 2017 08:59:49 +0900 Subject: [PATCH 2/5] gofmt --- samples/tutorials/go/columnstore.go | 12 +++++++----- samples/tutorials/go/connect.go | 10 ++++++---- samples/tutorials/go/crud.go | 12 +++++++----- samples/tutorials/go/orm.go | 12 +++++++----- 4 files changed, 27 insertions(+), 19 deletions(-) diff --git a/samples/tutorials/go/columnstore.go b/samples/tutorials/go/columnstore.go index bf8883f453..51e804583f 100644 --- a/samples/tutorials/go/columnstore.go +++ b/samples/tutorials/go/columnstore.go @@ -9,11 +9,13 @@ import ( _ "github.com/denisenkom/go-mssqldb" ) -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" -var database = "SampleDB" +var ( + server = "localhost" + port = 1433 + user = "sa" + password = "your_password" + database = "SampleDB" +) // Delete an employee from database func ExecuteAggregateStatement(db *sql.DB) { diff --git a/samples/tutorials/go/connect.go b/samples/tutorials/go/connect.go index 7f76c9889e..bcea682c3b 100644 --- a/samples/tutorials/go/connect.go +++ b/samples/tutorials/go/connect.go @@ -8,10 +8,12 @@ import ( _ "github.com/denisenkom/go-mssqldb" ) -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" +var ( + server = "localhost" + port = 1433 + user = "sa" + password = "your_password" +) func main() { connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d", diff --git a/samples/tutorials/go/crud.go b/samples/tutorials/go/crud.go index ca5637bdd8..4ae8ab44ea 100644 --- a/samples/tutorials/go/crud.go +++ b/samples/tutorials/go/crud.go @@ -8,11 +8,13 @@ import ( _ "github.com/denisenkom/go-mssqldb" ) -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" -var database = "SampleDB" +var ( + server = "localhost" + port = 1433 + user = "sa" + password = "your_password" + database = "SampleDB" +) // Create an employee func CreateEmployee(db *sql.DB, name string, location string) (int64, error) { diff --git a/samples/tutorials/go/orm.go b/samples/tutorials/go/orm.go index 61ed4349b6..7b7333a5c4 100644 --- a/samples/tutorials/go/orm.go +++ b/samples/tutorials/go/orm.go @@ -7,11 +7,13 @@ import ( _ "github.com/jinzhu/gorm/dialects/mssql" ) -var server = "localhost" -var port = 1433 -var user = "sa" -var password = "your_password" -var database = "SampleDB" +var ( + server = "localhost" + port = 1433 + user = "sa" + password = "your_password" + database = "SampleDB" +) type User struct { gorm.Model From 61210d3bf1d8aeb01308d5977e376351b5ebcf08 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 9 Jun 2017 09:03:17 +0900 Subject: [PATCH 3/5] fix godoc --- samples/tutorials/go/columnstore.go | 2 +- samples/tutorials/go/crud.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/samples/tutorials/go/columnstore.go b/samples/tutorials/go/columnstore.go index 51e804583f..5b65fcf822 100644 --- a/samples/tutorials/go/columnstore.go +++ b/samples/tutorials/go/columnstore.go @@ -17,7 +17,7 @@ var ( database = "SampleDB" ) -// Delete an employee from database +// ExecuteAggregateStatement output summary of prices func ExecuteAggregateStatement(db *sql.DB) { result, err := db.Prepare("SELECT SUM(Price) as sum FROM Table_with_5M_rows") if err != nil { diff --git a/samples/tutorials/go/crud.go b/samples/tutorials/go/crud.go index 4ae8ab44ea..72e87b9748 100644 --- a/samples/tutorials/go/crud.go +++ b/samples/tutorials/go/crud.go @@ -16,7 +16,7 @@ var ( database = "SampleDB" ) -// Create an employee +// CreateEmployee create an employee func CreateEmployee(db *sql.DB, name string, location string) (int64, error) { tsql := fmt.Sprintf("INSERT INTO TestSchema.Employees (Name, Location) VALUES ('%s','%s');", name, location) @@ -28,7 +28,7 @@ func CreateEmployee(db *sql.DB, name string, location string) (int64, error) { return result.LastInsertId() } -// Read all employees +// ReadEmployees read all employees func ReadEmployees(db *sql.DB) (int, error) { tsql := fmt.Sprintf("SELECT Id, Name, Location FROM TestSchema.Employees;") rows, err := db.Query(tsql) @@ -52,7 +52,7 @@ func ReadEmployees(db *sql.DB) (int, error) { return count, nil } -// Update an employee's information +// UpdateEmployee update an employee's information func UpdateEmployee(db *sql.DB, name string, location string) (int64, error) { tsql := fmt.Sprintf("UPDATE TestSchema.Employees SET Location = '%s' WHERE Name= '%s'", location, name) @@ -64,7 +64,7 @@ func UpdateEmployee(db *sql.DB, name string, location string) (int64, error) { return result.LastInsertId() } -// Delete an employee from database +// DeleteEmployee delete an employee from database func DeleteEmployee(db *sql.DB, name string) (int64, error) { tsql := fmt.Sprintf("DELETE FROM TestSchema.Employees WHERE Name='%s';", name) result, err := db.Exec(tsql) From 43c3cc6f4ec8a655453e4ba156d8e33444a4ef3d Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 9 Jun 2017 09:05:58 +0900 Subject: [PATCH 4/5] check errors --- samples/tutorials/go/crud.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/samples/tutorials/go/crud.go b/samples/tutorials/go/crud.go index 72e87b9748..e423a4a437 100644 --- a/samples/tutorials/go/crud.go +++ b/samples/tutorials/go/crud.go @@ -88,17 +88,29 @@ func main() { // Create employee createId, err := CreateEmployee(conn, "Jake", "United States") + if err != nil { + log.Fatal("CreateEmployee failed:", err.Error()) + } fmt.Printf("Inserted ID: %d successfully.\n", createId) // Read employees count, err := ReadEmployees(conn) + if err != nil { + log.Fatal("ReadEmployees failed:", err.Error()) + } fmt.Printf("Read %d rows successfully.\n", count) // Update from database updateId, err := UpdateEmployee(conn, "Jake", "Poland") + if err != nil { + log.Fatal("UpdateEmployee failed:", err.Error()) + } fmt.Printf("Updated row with ID: %d successfully.\n", updateId) // Delete from database rows, err := DeleteEmployee(conn, "Jake") + if err != nil { + log.Fatal("DeleteEmployee failed:", err.Error()) + } fmt.Printf("Deleted %d rows successfully.\n", rows) } From 9fd334d1f3edd4b09418ebeb0b99459442cf8491 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 9 Jun 2017 09:09:20 +0900 Subject: [PATCH 5/5] golint --- samples/tutorials/go/crud.go | 10 +++++----- samples/tutorials/go/orm.go | 15 ++++++++++----- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/samples/tutorials/go/crud.go b/samples/tutorials/go/crud.go index e423a4a437..4b292d10c6 100644 --- a/samples/tutorials/go/crud.go +++ b/samples/tutorials/go/crud.go @@ -37,7 +37,7 @@ func ReadEmployees(db *sql.DB) (int, error) { return -1, err } defer rows.Close() - var count int = 0 + count := 0 for rows.Next() { var name, location string var id int @@ -87,11 +87,11 @@ func main() { defer conn.Close() // Create employee - createId, err := CreateEmployee(conn, "Jake", "United States") + createID, err := CreateEmployee(conn, "Jake", "United States") if err != nil { log.Fatal("CreateEmployee failed:", err.Error()) } - fmt.Printf("Inserted ID: %d successfully.\n", createId) + fmt.Printf("Inserted ID: %d successfully.\n", createID) // Read employees count, err := ReadEmployees(conn) @@ -101,11 +101,11 @@ func main() { fmt.Printf("Read %d rows successfully.\n", count) // Update from database - updateId, err := UpdateEmployee(conn, "Jake", "Poland") + updateID, err := UpdateEmployee(conn, "Jake", "Poland") if err != nil { log.Fatal("UpdateEmployee failed:", err.Error()) } - fmt.Printf("Updated row with ID: %d successfully.\n", updateId) + fmt.Printf("Updated row with ID: %d successfully.\n", updateID) // Delete from database rows, err := DeleteEmployee(conn, "Jake") diff --git a/samples/tutorials/go/orm.go b/samples/tutorials/go/orm.go index 7b7333a5c4..155c784c08 100644 --- a/samples/tutorials/go/orm.go +++ b/samples/tutorials/go/orm.go @@ -15,12 +15,14 @@ var ( database = "SampleDB" ) +// User represents a user account type User struct { gorm.Model FirstName string LastName string } +// Task represents a task for the user type Task struct { gorm.Model Title string @@ -29,6 +31,7 @@ type Task struct { UserID uint } +// ReadAllTasks read all tasks func ReadAllTasks(db *gorm.DB) { var users []User var tasks []Task @@ -44,16 +47,18 @@ func ReadAllTasks(db *gorm.DB) { } } -func UpdateSomeonesTask(db *gorm.DB, userId int) { +// UpdateSomeonesTask update someone's task +func UpdateSomeonesTask(db *gorm.DB, userID int) { var task Task - db.Where("user_id = ?", userId).First(&task).Update("Title", "Buy donuts for Luis") + db.Where("user_id = ?", userID).First(&task).Update("Title", "Buy donuts for Luis") fmt.Printf("Title: %s\nDueDate: %s\nIsComplete:%t\n\n", task.Title, task.DueDate, task.IsComplete) } -func DeleteSomeonesTasks(db *gorm.DB, userId int) { - db.Where("user_id = ?", userId).Delete(&Task{}) - fmt.Printf("Deleted all tasks for user %d", userId) +// DeleteSomeonesTasks delete someone's task +func DeleteSomeonesTasks(db *gorm.DB, userID int) { + db.Where("user_id = ?", userID).Delete(&Task{}) + fmt.Printf("Deleted all tasks for user %d", userID) } func main() {