Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Microbenchmark - Support different hipblasLt data types in dist_inference #590

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

yzygitzh
Copy link
Member

@yzygitzh yzygitzh commented Dec 11, 2023

Description
Support different data types in different hipblasLt versions for dist_inference

@yzygitzh yzygitzh requested a review from a team as a code owner December 11, 2023 08:02
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c2096e) 86.11% compared to head (5d583db) 86.11%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.10     #590   +/-   ##
=============================================
  Coverage         86.11%   86.11%           
=============================================
  Files                97       97           
  Lines              6873     6873           
=============================================
  Hits               5919     5919           
  Misses              954      954           
Flag Coverage Δ
cpu-python3.6-unit-test 71.81% <ø> (ø)
cpu-python3.7-unit-test 71.81% <ø> (ø)
cpu-python3.8-unit-test 72.22% <ø> (ø)
cuda-unit-test 84.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yzygitzh yzygitzh changed the base branch from main to release/0.10 December 11, 2023 09:07
@cp5555 cp5555 mentioned this pull request Dec 11, 2023
30 tasks
@cp5555 cp5555 changed the title Benchmarks: Microbenchmark - add workaround for different hipblasLt data types Benchmarks: Microbenchmark - Support different hipblasLt data types in dist_inference Dec 12, 2023
@cp5555 cp5555 added benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels Dec 12, 2023
@yzygitzh yzygitzh merged commit 606ff19 into microsoft:release/0.10 Dec 13, 2023
20 checks passed
@yzygitzh yzygitzh deleted the ziyue/hipblaslt-workaround branch December 13, 2023 03:16
abuccts pushed a commit that referenced this pull request Jan 3, 2024
…n dist_inference (#590)

**Description**
Support different data types in different hipblasLt versions for
dist_inference
abuccts added a commit that referenced this pull request Jan 8, 2024
**Description**

Cherry-pick bug fixes from v0.10.0 to main.

**Major Revisions**

* Benchmarks: Microbenchmark - Support different hipblasLt data types in dist_inference #590
* Benchmarks: Microbenchmark - Support in-place for NCCL/RCCL benchmark #591
* Bug Fix - Fix NUMA Domains Swap Issue in NDv4 Topology File #592
* Benchmarks: Microbenchmark - Add data type option for NCCL and RCCL tests #595
* Benchmarks: Bug Fix - Make metrics of dist-inference-cpp aligned with PyTorch version #596
* CI/CD - Add ndv5 topo file #597
* Benchmarks: Microbenchmark - Improve AMD GPU P2P performance with fine-grained GPU memory #593
* Benchmarks: Build Pipeline - fix nccl and nccl test version to 2.18.3 to resolve hang issue in cuda12.2 docker #599
* Dockerfile - Bug fix for rocm docker build and deploy #598
* Benchmarks: Microbenchmark - Adapt to hipblasLt data type changes #603
* Benchmarks: Micro benchmarks - Update hipblaslt metric unit to tflops #604
* Monitor - Upgrade pyrsmi to amdsmi python library. #601
* Benchmarks: Micro benchmarks - add fp8 and initialization for hipblaslt benchmark #605
* Dockerfile - Add rocm6.0 dockerfile #602
* Bug Fix - Bug fix for latest megatron-lm benchmark #600
* Docs - Upgrade version and release note #606

Co-authored-by: Ziyue Yang <ziyyang@microsoft.com>
Co-authored-by: Yang Wang <yangwang1@microsoft.com>
Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com>
Co-authored-by: guoshzhao <guzhao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants