-
Notifications
You must be signed in to change notification settings - Fork 6
Populate empty package READMEs with usage examples #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
|
if you’re including snippets, they should be grounded with example from the tests folder
if you’re including snippets, they should be grounded with example from the tests folder
|
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
|
too many details. If showing snippets just show basic use case
|
|
@copilot too many details. If showing snippets just show basic use case |
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
heyitsaamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot work on the fixes i suggested
…erver/client examples and docs links Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
…valid constructor params Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
heyitsaamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot fix
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the README documentation for five Microsoft Teams AI Library packages by adding comprehensive installation and usage examples. The goal is to provide clearer onboarding documentation for developers using these packages.
- Replaced generic documentation links with specific installation instructions using
uv add - Added practical code examples showing how to instantiate and use core classes from each package
- Standardized README format across packages with Installation and Usage sections
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/openai/README.md | Added installation instructions and basic usage example for OpenAICompletionsAIModel with ChatPrompt |
| packages/mcpplugin/README.md | Created complete README with MCP client and server usage examples, including tool registration |
| packages/devtools/README.md | Added installation and usage example showing DevToolsPlugin integration with App |
| packages/ai/README.md | Added comprehensive examples for ChatPrompt and Function calling patterns |
| packages/a2aprotocol/README.md | Added A2A server and client usage examples with agent configuration |
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
…d setup Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
- Remove support for 3.14 (#207) - Add Federated Identity Credentials support (#203) - Add User Managed Identity support via MSAL (#192) - Introduce msal (#191) - Populate empty package READMEs with usage examples (#196) - Rename Teams AI to Teams SDK 🎉 (#201) - HTTPPlugin : Add a builder option to provide custom server (enables providing options like ssl etc) (#185) - get type hint of class, not object (#202) - Temporary: skip streaming tests (#200) - Fix workflow
Populate empty package READMEs with usage examples.
Completed Tasks ✓
Summary
Updated 5 package READMEs based on review feedback:
Updated Packages
microsoft-teams-ai (37 → 59 lines)
microsoft-teams-mcpplugin (39 → 74 lines)
microsoft-teams-a2a (42 → 75 lines)
microsoft-teams-openai (32 lines)
microsoft-teams-devtools (38 → 36 lines)
Each README now shows realistic usage patterns verified against test applications.
Validation
✓ All linting checks pass (ruff)
✓ All formatting checks pass
✓ Documentation-only changes
✓ Examples match test implementation patterns
✓ All examples use ChatPrompt consistently
✓ A2A examples grounded in actual test code
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.