-
Notifications
You must be signed in to change notification settings - Fork 9
Simplify setting http response after activity processing #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now that we aren't using events for responses, I think we should make these fundamental changes:
|
|
Refactored the activity processor out of the event manager and into the plugin processor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
….com/microsoft/teams.py into kavin/simplify-activity-response
….com/microsoft/teams.py into kavin/simplify-activity-response
…/microsoft/teams.py into kavin/simplify-activity-response
heyitsaamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested


Linked PR: microsoft/teams.ts#398
This is how the architecture looked like before
This is what it looks like now: