diff --git a/.github/actions/spelling/allow/allow.txt b/.github/actions/spelling/allow/allow.txt index 35742a6111e..ccc5c02d972 100644 --- a/.github/actions/spelling/allow/allow.txt +++ b/.github/actions/spelling/allow/allow.txt @@ -1,4 +1,5 @@ apc +breadcrumb calt ccmp changelog diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.cpp b/src/cascadia/TerminalSettingsEditor/MainPage.cpp index 381e33a0ad6..19f1340be11 100644 --- a/src/cascadia/TerminalSettingsEditor/MainPage.cpp +++ b/src/cascadia/TerminalSettingsEditor/MainPage.cpp @@ -314,28 +314,28 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation *this); _profileViewModelChangedRevoker = _lastProfilesNavState.Profile().PropertyChanged(winrt::auto_revoke, [=](auto&&, const PropertyChangedEventArgs& args) { - const auto settingName{ args.PropertyName() }; - if (settingName == L"CurrentPage") + const auto settingName{ args.PropertyName() }; + if (settingName == L"CurrentPage") + { + const auto currentPage = _lastProfilesNavState.Profile().CurrentPage(); + if (currentPage == L"Base") { - const auto currentPage = _lastProfilesNavState.Profile().CurrentPage(); - if (currentPage == L"Base") - { - contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); - _breadcrumbs.Clear(); - _breadcrumbs.Append(RS_(L"Nav_ProfileDefaults/Content")); - } - else if (currentPage == L"Appearance") - { - contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); - _breadcrumbs.Append(RS_(L"Profile_Appearance/Header")); - } - else if (currentPage == L"Advanced") - { - contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); - _breadcrumbs.Append(RS_(L"Profile_Advanced/Header")); - } + contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); + _breadcrumbs.Clear(); + _breadcrumbs.Append(RS_(L"Nav_ProfileDefaults/Content")); } - }); + else if (currentPage == L"Appearance") + { + contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); + _breadcrumbs.Append(RS_(L"Profile_Appearance/Header")); + } + else if (currentPage == L"Advanced") + { + contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); + _breadcrumbs.Append(RS_(L"Profile_Advanced/Header")); + } + } + }); contentFrame().Navigate(xaml_typename(), _lastProfilesNavState); _breadcrumbs.Append(RS_(L"Nav_ProfileDefaults/Content")); @@ -451,7 +451,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation _lastProfilesNavState.Profile().CurrentPage(L"Base"); } - void MainPage::_InitializeProfilesList() { const auto menuItems = SettingsNav().MenuItems(); diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.xaml b/src/cascadia/TerminalSettingsEditor/MainPage.xaml index 926072dd7af..98fc28e9efe 100644 --- a/src/cascadia/TerminalSettingsEditor/MainPage.xaml +++ b/src/cascadia/TerminalSettingsEditor/MainPage.xaml @@ -43,9 +43,9 @@ TabFocusNavigation="Cycle"> + ItemsSource="{x:Bind Breadcrumbs}"> 28 diff --git a/src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml b/src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml index 3508bfff572..33c84d738e1 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml +++ b/src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml @@ -35,84 +35,84 @@ Margin="{StaticResource StandardIndentMargin}" Style="{StaticResource DisclaimerStyle}" Visibility="{x:Bind State.Profile.IsBaseLayer}" /> - - + + + ClearSettingValue="{x:Bind State.Profile.ClearSuppressApplicationTitle}" + HasSettingValue="{x:Bind State.Profile.HasSuppressApplicationTitle, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.SuppressApplicationTitleOverrideSource, Mode=OneWay}"> + ClearSettingValue="{x:Bind State.Profile.ClearAntialiasingMode}" + HasSettingValue="{x:Bind State.Profile.HasAntialiasingMode, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.AntialiasingModeOverrideSource, Mode=OneWay}" + Style="{StaticResource ExpanderSettingContainerStyle}"> + ItemTemplate="{StaticResource EnumRadioButtonTemplate}" + ItemsSource="{x:Bind AntiAliasingModeList, Mode=OneWay}" + SelectedItem="{x:Bind CurrentAntiAliasingMode, Mode=TwoWay}" /> + ClearSettingValue="{x:Bind State.Profile.ClearAltGrAliasing}" + HasSettingValue="{x:Bind State.Profile.HasAltGrAliasing, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.AltGrAliasingOverrideSource, Mode=OneWay}"> + ClearSettingValue="{x:Bind State.Profile.ClearSnapOnInput}" + HasSettingValue="{x:Bind State.Profile.HasSnapOnInput, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.SnapOnInputOverrideSource, Mode=OneWay}"> + ClearSettingValue="{x:Bind State.Profile.ClearHistorySize}" + HasSettingValue="{x:Bind State.Profile.HasHistorySize, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.HistorySizeOverrideSource, Mode=OneWay}"> + LargeChange="100" + Minimum="0" + SmallChange="10" + Style="{StaticResource NumberBoxSettingStyle}" + Value="{x:Bind State.Profile.HistorySize, Mode=TwoWay}" /> + ClearSettingValue="{x:Bind State.Profile.ClearCloseOnExit}" + HasSettingValue="{x:Bind State.Profile.HasCloseOnExit, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.CloseOnExitOverrideSource, Mode=OneWay}" + Style="{StaticResource ExpanderSettingContainerStyle}"> + ItemTemplate="{StaticResource EnumRadioButtonTemplate}" + ItemsSource="{x:Bind CloseOnExitModeList, Mode=OneWay}" + SelectedItem="{x:Bind CurrentCloseOnExitMode, Mode=TwoWay}" /> + ClearSettingValue="{x:Bind State.Profile.ClearBellStyle}" + HasSettingValue="{x:Bind State.Profile.HasBellStyle, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.BellStyleOverrideSource, Mode=OneWay}" + Style="{StaticResource ExpanderSettingContainerStyle}"> + IsChecked="{x:Bind IsBellStyleFlagSet(1), BindBack=SetBellStyleAudible, Mode=TwoWay}" /> + IsChecked="{x:Bind IsBellStyleFlagSet(2), BindBack=SetBellStyleWindow, Mode=TwoWay}" /> + IsChecked="{x:Bind IsBellStyleFlagSet(4), BindBack=SetBellStyleTaskbar, Mode=TwoWay}" /> diff --git a/src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml b/src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml index a57b8e9344b..2d1b80bbcc8 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml +++ b/src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml @@ -41,32 +41,32 @@ Margin="{StaticResource StandardIndentMargin}" Style="{StaticResource DisclaimerStyle}" Visibility="{x:Bind State.Profile.IsBaseLayer}" /> - + + Width="350" + Height="160" + Margin="0,0,0,12" + HorizontalAlignment="Left" + BorderBrush="{ThemeResource SystemControlForegroundBaseMediumLowBrush}" + BorderThickness="1" /> + SourceProfile="{x:Bind State.Profile, Mode=OneWay}" /> + Style="{StaticResource SubtitleTextBlockStyle}" /> + x:Uid="Profile_Opacity" + ClearSettingValue="{x:Bind State.Profile.ClearOpacity}" + HasSettingValue="{x:Bind State.Profile.HasOpacity, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.OpacityOverrideSource, Mode=OneWay}"> @@ -74,22 +74,22 @@ + Grid.Column="0" + Value="{x:Bind local:Converters.PercentageToPercentageValue(State.Profile.Opacity), BindBack=State.Profile.SetAcrylicOpacityPercentageValue, Mode=TwoWay}" /> + Style="{StaticResource SliderValueLabelStyle}" + Text="{x:Bind local:Converters.AppendPercentageSign(OpacitySlider.Value), Mode=OneWay}" /> + ClearSettingValue="{x:Bind State.Profile.ClearUseAcrylic}" + HasSettingValue="{x:Bind State.Profile.HasUseAcrylic, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.UseAcrylicOverrideSource, Mode=OneWay}"> + IsOn="{x:Bind State.Profile.UseAcrylic, Mode=TwoWay}" /> @@ -97,107 +97,107 @@ + Style="{StaticResource SubtitleTextBlockStyle}" /> + ClearSettingValue="{x:Bind State.Profile.ClearPadding}" + HasSettingValue="{x:Bind State.Profile.HasPadding, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.PaddingOverrideSource, Mode=OneWay}"> + Grid.Column="0" + Value="{x:Bind local:Converters.MaxValueFromPaddingString(State.Profile.Padding), BindBack=State.Profile.SetPadding, Mode=TwoWay}" /> + Style="{StaticResource SliderValueLabelStyle}" + Text="{Binding ElementName=PaddingSlider, Path=Value, Mode=OneWay}" /> + ClearSettingValue="{x:Bind State.Profile.ClearScrollState}" + HasSettingValue="{x:Bind State.Profile.HasScrollState, Mode=OneWay}" + SettingOverrideSource="{x:Bind State.Profile.ScrollStateOverrideSource, Mode=OneWay}" + Style="{StaticResource ExpanderSettingContainerStyle}"> + ItemTemplate="{StaticResource EnumRadioButtonTemplate}" + ItemsSource="{x:Bind ScrollStateList, Mode=OneWay}" + SelectedItem="{x:Bind CurrentScrollState, Mode=TwoWay}" /> + Visibility="{x:Bind State.Profile.EditableUnfocusedAppearance, Mode=OneWay}"> + Style="{StaticResource TitleTextBlockStyle}" /> + SourceProfile="{x:Bind State.Profile, Mode=OneWay}" + Visibility="{x:Bind State.Profile.ShowUnfocusedAppearance, Mode=OneWay}" /> diff --git a/src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml b/src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml index 9b62449a127..ecce8321a06 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml +++ b/src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml @@ -29,7 +29,7 @@ - + @@ -45,171 +45,170 @@ Margin="{StaticResource StandardIndentMargin}" Style="{StaticResource DisclaimerStyle}" Visibility="{x:Bind State.Profile.IsBaseLayer}" /> - - + + - - - - - - - - - - -