Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ConhostConnection to the official ConPTY API #1131

Open
DHowett-MSFT opened this issue Jun 4, 2019 · 0 comments

Comments

@DHowett-MSFT
Copy link
Member

commented Jun 4, 2019

Making the switch from spawning conhost directly to using CreatePseudoConsole and otherwise hosting a pseudoconsole session affords us a number of benefits.

  • Fixes #1090
  • Isolates Windows Terminal's understanding of conhost's internals
  • Allows us to CreateProcess the shell directly and track its exit independent from that of the pseudoconsole host
    • which allows us to manage the shell and the pseudoconsole host in separate jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.