Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Tab does not allow to type after resize #12689

Closed
buehler opened this issue Mar 14, 2022 · 5 comments
Closed

Terminal Tab does not allow to type after resize #12689

buehler opened this issue Mar 14, 2022 · 5 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase

Comments

@buehler
Copy link

buehler commented Mar 14, 2022

Windows Terminal version

1.11.3471.1

Windows build number

10.0.22000.0

Other Software

  • git bash: git version 2.35.1.windows.2 (loaded via terminal json)
  • git bash was installed in terminal via git installer
  • installed ZSH inside git bash (zsh --version: zsh 5.8 (x86_64-pc-msys))
  • oh-my-zsh

Steps to reproduce

  1. Open a terminal with the git bash zsh tab
  2. Test out writing something
  3. Resize the terminal (or make it full screen and back)
  4. Try to type again

Terminal

Expected Behavior

It should be able to use my keyboard after resizing the terminal :)

Actual Behavior

I cannot type anything.

It only works when I start the terminal, then resize the window and then type. If I resize the window after I typed something, I cannot type anything after resizing the window.

@buehler buehler added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 14, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 14, 2022
@zadjii-msft
Copy link
Member

curious. Does this repro for other shells(cmd, powershell)? Do you have anything like X Mouse Button or WizMouse installed? Do you have PowerToys installed?

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Mar 14, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 14, 2022
@buehler
Copy link
Author

buehler commented Mar 14, 2022

Hey @zadjii-msft

Just tested:

  • with powershell: it works as intended
  • with git bash only (ZSH deactivated): works as intended

darn. :-(

I know... it is "not your problem" now :-) but do you have any insights into what the problem might be?

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 14, 2022
@zadjii-msft
Copy link
Member

Honestly, no 😕

Maybe they've got a bug in how they handle resizes that gets the shell into a bad state?

It may have to do with your prompt - you've got that path on the right side of the window - perhaps that's confusing the shell. Maybe try disabling the prompt customization, see if that helps?

I'm gonna close this out since this seems like a bug that needs to be moved upstream to zsh (or even oh-my-zsh), but feel free to link the thread back to this one, so others who run into this can follow up as well.

@buehler
Copy link
Author

buehler commented Mar 15, 2022

@zadjii-msft
Just to keep you in the loop: effectively, it is an error of "oh my zsh". There is a local function git_prompt_info that is causing the error as referenced in the issue (ohmyzsh/ohmyzsh#9953)

Thank you for the help!

@nofacer
Copy link

nofacer commented Dec 19, 2022

They says it's not from them ohmyzsh/ohmyzsh#9953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

3 participants