Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - List Icons in the default profiles.json #1456

Closed
JushBJJ opened this issue Jun 23, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@JushBJJ
Copy link

commented Jun 23, 2019

Summary of the new feature/enhancement

It took a while for me to figure out how to change the icons using the JSON file somewhat, I looked into https://github.com/microsoft/terminal/tree/master/src/cascadia/CascadiaPackage/ProfileIcons to see if I can use them and it turns out, yes.

Proposed technical implementation details (optional)

    "Icons":
    [
        {
            "Powershell" : "ms-appx:///ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.png",
            "Linux" : "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.scale-100.png",
            "CMD" : "ms-appx:///ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.png"
        }
    ]

This example could be added in the auto-generated profiles.json file to make things easier for users to choose icons if they wanted to do so.

@zprood

This comment has been minimized.

Copy link

commented Jun 23, 2019

+1 for this feature request, I'd like to change the icon to Ubuntu logo instead of Linux logo.
Cheers !

@cinnamon-msft

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

If you'd like to change the icon of a profile, feel free to change the path of the "icon" property to where your desired icon is 😊
In terms of creating an object to store all of the icons, we'd like to keep the icons separated by profile because it'll directly translate to the settings UI once it's implemented i.e. we won't be having a page for only icons, however we'll have a page for individual profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.