-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEGATHREAD: Breaking settings changes in version 0.11! #5458
Comments
Out of curiosity, any reason why I myself had this problem and got into #5489 even though I scanned changelog before the upgrade, but haven't picked up that I have actually to change something in my config 🙂 |
You might want to reword that from "move them out" as that really doesn't say nearly enough to anyone. Be specific:
|
@bmarkovic that’s a great suggestion, thank you. I appreciate that you edited your comment. |
In my particular case this didn't restore functionality of keybindings, did something change about the format (or the JSON key name)? |
Interesting. If you scroll down, do you happen to have a separate copy of |
Unfortunately, no. I see in #3600 that "command" is an object now, is that mandatory (i.e. the old format where "command" is string no longer works)? Also in my config, "keys" is an array, here it is a string. E.g. {
"command" : "newTab",
"keys" :
[
"ctrl+t"
]
}, |
Nah, action+command (the object format) isn’t mandatory, and keys can be either a string or an array... Would you mind sharing a gist of your settings? |
Off course not. https://gist.github.com/bmarkovic/485363256672f4be66379c4d9a604c81 Edit: In case someone else comes along with an issue like this, the issue is that A LOT of these settings have changed and are no longer valid. If you are using VS.Code it will respect the new JSON schema, underline the things that are no longer valid, and you will have to refer to: https://github.com/microsoft/terminal/blob/master/doc/cascadia/SettingsSchema.md for the format of the new settings. |
Ah, I'm gonna guess that the key bindings that aren't working are the Ctrl+Shift+# ones. Sorry our documentation failed you here -- those are included in the legacy settings removal from #5190. Right now, I think those old bindings are replacing the default bindings with their no-longer-effective legacy versions and you can just delete them. Here's a better way out, though: Judging by all the key bindings, the format, and the profiles containing every config option, it looks like that settings file predates 0.2. I really think it's great that you've been with us that long (since our first public release!) Thanks! Versions of Terminal after 0.5 lay down a cool new settings template that's more streamlined, and is a bit better-documented. There's a set of "default" settings now that live in the terminal package that your settings get applied on top of. It's not a requirement by any means, but you might be a bit happier in general if you spend a couple minutes migrating.
The settings model change from 0.5 means you don't need to specify every option in every profile, and you don't need to be quite so aggressive in customizing everything. I took a stab at it -- this should be equivalent to your old settings, but with a whole bunch of the legacy cruft removed. https://gist.github.com/DHowett-MSFT/ec2d24cf2b84e1555fb56a1192e4fb94 I didn't know if you used alt+N for switching tabs, but those were some of the old key bindings in your settings and I didn't want to go stomp them 😄 |
The hallmark of an old (version 0.2) settings file is ctrl+w being bound, and being bound to |
Hah, I've done it myself too in the meantime (I updated the alt+ tab switches, as I did use them) as well. I will take a look at your take on it too. This machine is not really my day-job driver (contrary to, I guess, most people, the Windows box is a play thing, and I earn my bread and butter on a Linux desktop) so that might be why I've not updated all this before. Here is a pretty verbatim translation of my settings file to new schema (with a change here and there to make use of some new, previously unavailable settings), from my quick test they all do work after I change the target commands and format. I'll look at the "no-legacy cruft" version you pasted as well (I don't want get attached my non-standard bindings) and probably make some combo for future use. Thank you for the help, and I do love the program. It has completely replaced ConEmu as the go-to terminal emulator on Windows for me. |
Happy to hear that, and I'm sorry it's been a bit of a bumpy ride here on the preview train 😅 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
From #5611
Thanks! Maybe try changing
|
Is black the new default? The regenerated settings.json does not contain any color schemes. |
@tomm1e That's entirely intentional. We figured that every user didn't need to see a full copy of every default scheme in their settings file, so we moved them to |
Those links are going to go somewhere useful SoonTM. Please bear with us as we put the finishing touches on the actual docs 😉 |
@zadjii-msft Thanks for that update. Being a technical writer myself I always gets antsy when documentation seems to be forgotten. 😅 |
I noticed the blog article talks about using things like eg.
We should document this as IMO its not clear that |
Text that is broken into newlines due to window size is doing so because of a bug, and the solution isn't to set Do you have a specific repro that causes broken multiline text? |
(There are three independent copy flags. |
@DHowett-MSFT I understand that to be the case regarding the different options, but it seems then there is a bug that affect that and its "fixed" by setting Repro for me is really simple for me and I can even dynamically toggle that and have it broken/fixed.
As you can see on that output, the line when pasted is split into multi line and ran as 2 commands.
Please note im not copying with For reference, this is my relevant config:
|
Ok, oddly enough while I just did this while creating this comment and it caused the output I pasted (broken line) and it happened multiple times since the update. I just ran it once again after, just to check other cases and it worked correctly, which has me really confused now. |
Any reason why we haven't gotten a GUI for changing settings yet? |
@ScribbleNerd because that will take months of work that we couldn't complete until we nailed the basics of actually being a terminal? That work is being tracked in #1564. |
yeah not meaning to sound condescending but its a cli tool for cli competent people, so it makes far more sense to work on the core functionality and cli user features rather than trying to make it easy point and click to make pretty - at least until all the main things are done, upvote for html link handler haha |
I only changed the default profile to cmd.exe in last version. then today after update it showing me global deprecated error over and over again. |
How about automatically converting the file if older format is detected: seeing the format changes it appears to be possible. Seeing how full of comments is this issue I think this could solve problems for a lot of people. |
Got to say, I found this extremely jarring for a product that that is at GA status. |
Only people who were using the Preview build will encounter breaking changes. The preview build was offered with no warranties (express or implied.) I’m sorry it was jarring. Settings migration is planned for any updates to the stable channel that require settings model changes. |
BREAKING SETTINGS CHANGES IN 0.11
globals
dictionary, you'll want to move them out.globals
to the root of your settings file and delete the emptyglobals
object.defaultProfile
requestedTheme
has been renamed totheme
(Rename 'requestedTheme' to 'theme' #5265)profiles.json
has been renamed tosettings.json
. This should be transparent to you as we'll rename it on first launch (rename profiles.json to settings.json, clean up the defaults #5199)splitPane
split
mode, it'll default toautomatic
(Use an Automatic split for splitPane by default #5194)copy
's original and poorly-understoodtrimWhitespace
argument is now calledsingleLine
to indicate that it will, in fact, copy text as a single line (Rename copy keybinding arg #5216)Do your settings look like this?
Then change them to look like this:
Or even better, make a backup of your settings file, and delete the contents entirely. We'll re-generate the file with some better formatting and more sane defaults, and you can copy the modifications you want back in.
The text was updated successfully, but these errors were encountered: