Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Convert CommandHistory to a std::shared_ptr #1161
Summary of the Pull Request
CommandHistory becomes a std::shared_ptr. Minor changes in code and unit tests.
My previous PR 1148 was bad quality. you can cancel it.
Detailed Description of the Pull Request / Additional comments
Previous commit was a mistake, it involves modifcations and both the migration to vs2019 and platform toolset v142.
Validation Steps Performed
Manuel test of running tab and ask for cmd and type command, and ask for history...
I have transformed the 'static COORD calculatePopupSize(const CommandHistory& history)' to take back a reference. The caller is simple:
I think its a good balanced between shared_ptr and reference.