Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audit build step for code formatting check #1208

Merged
merged 5 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@adiviness
Copy link
Contributor

commented Jun 11, 2019

Summary of the Pull Request

Adds build step to enforce code formatting on PR changes

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


#.SYNOPSIS
# Checks for code formatting errors. Will throw exception if any are found.
function Invoke-CheckBadCodeFormatting() {

This comment has been minimized.

Copy link
@DHowett-MSFT

DHowett-MSFT Jun 11, 2019

Member

probably we can just unencapsulate this code and make it the toplevel contents of the script file.

This comment has been minimized.

Copy link
@adiviness

adiviness Jun 11, 2019

Author Contributor

I'd prefer to leave it encapsulated, as a personal preference.

adiviness added some commits Jun 11, 2019

@adiviness adiviness marked this pull request as ready for review Jun 11, 2019

@carlos-zamora
Copy link
Member

left a comment

:shipit:

@adiviness adiviness merged commit fa36d43 into master Jun 11, 2019

6 checks passed

Terminal CI Build #0.0.1906.1115 had test failures
Details
Terminal CI (Build ARM64 Release) Build ARM64 Release succeeded
Details
Terminal CI (Build x64 Release) Build x64 Release succeeded
Details
Terminal CI (Build x86 Release) Build x86 Release succeeded
Details
Terminal CI (Static Analysis Build x64) Static Analysis Build x64 succeeded
Details
license/cla All CLA requirements met.
Details

@DHowett-MSFT DHowett-MSFT deleted the dev/austdi/enforce_formatting branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.