From 7d9da4dbe391f2822f2b84ace1dac0fbbea46bf5 Mon Sep 17 00:00:00 2001 From: nogunumo Date: Tue, 15 Dec 2020 03:28:06 +0900 Subject: [PATCH 1/2] Change Width to Height and6 px to 10px --- src/cascadia/TerminalApp/AppLogic.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cascadia/TerminalApp/AppLogic.cpp b/src/cascadia/TerminalApp/AppLogic.cpp index 1f6c1e7a227..6a2dcb54cf0 100644 --- a/src/cascadia/TerminalApp/AppLogic.cpp +++ b/src/cascadia/TerminalApp/AppLogic.cpp @@ -594,7 +594,7 @@ namespace winrt::TerminalApp::implementation // For whatever reason, there's about 6px of unaccounted-for space // in the application. I couldn't tell you where these 6px are // coming from, but they need to be included in this math. - proposedSize.Width += (tabControl.DesiredSize().Height + 6) * scale; + proposedSize.Height += (tabControl.DesiredSize().Height + 10) * scale; } return proposedSize; From fa115ac730484f6b3a6a0798a866418f9536c006 Mon Sep 17 00:00:00 2001 From: nogunumo Date: Tue, 15 Dec 2020 14:49:04 +0900 Subject: [PATCH 2/2] fix a comment --- src/cascadia/TerminalApp/AppLogic.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cascadia/TerminalApp/AppLogic.cpp b/src/cascadia/TerminalApp/AppLogic.cpp index 6a2dcb54cf0..f052341b53f 100644 --- a/src/cascadia/TerminalApp/AppLogic.cpp +++ b/src/cascadia/TerminalApp/AppLogic.cpp @@ -591,8 +591,8 @@ namespace winrt::TerminalApp::implementation auto tabControl = TabRowControl(); tabControl.Measure({ SHRT_MAX, SHRT_MAX }); - // For whatever reason, there's about 6px of unaccounted-for space - // in the application. I couldn't tell you where these 6px are + // For whatever reason, there's about 10px of unaccounted-for space + // in the application. I couldn't tell you where these 10px are // coming from, but they need to be included in this math. proposedSize.Height += (tabControl.DesiredSize().Height + 10) * scale; }