Skip to content

Fix flaky TimingProperty.ToString test by using an explicit format string #8502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Evangelink wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −32
Open

Fix flaky TimingProperty.ToString test by using an explicit format string #8502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Messages/TimingProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ public override string ToString()
var builder = new StringBuilder();
builder.Append($"{nameof(TimingInfo)} {{ ");
builder.Append($"{nameof(StartTime)} = ");
builder.Append(StartTime.ToString(CultureInfo.InvariantCulture));
builder.Append(StartTime.ToString("MM/dd/yyyy HH:mm:ss zzz", CultureInfo.InvariantCulture));
builder.Append($", {nameof(EndTime)} = ");
builder.Append(EndTime.ToString(CultureInfo.InvariantCulture));
builder.Append(EndTime.ToString("MM/dd/yyyy HH:mm:ss zzz", CultureInfo.InvariantCulture));
builder.Append($", {nameof(Duration)} = ");
Comment thread
Evangelink marked this conversation as resolved.
builder.Append(Duration.ToString("c", CultureInfo.InvariantCulture));
builder.Append(" }");
Expand Down
42 changes: 12 additions & 30 deletions test/UnitTests/Microsoft.Testing.Platform.UnitTests/Messages/TestNodePropertiesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,41 +155,23 @@ public void CancelledTestNodeStateProperty_WhenExceptionAndNoExplanation_ToStrin
[TestMethod]
public void TimingProperty_ToStringIsCorrect()
{
CultureInfo originalCulture = CultureInfo.CurrentCulture;
try
{
CultureInfo.CurrentCulture = CultureInfo.InvariantCulture;
DateTimeOffset startTime = new(2021, 9, 1, 0, 0, 0, default);
DateTimeOffset endTime = new(2021, 9, 1, 1, 2, 3, default);
TimeSpan duration = endTime - startTime;
Assert.AreEqual(
"TimingProperty { GlobalTiming = TimingInfo { StartTime = 09/01/2021 00:00:00 +00:00, EndTime = 09/01/2021 01:02:03 +00:00, Duration = 01:02:03 }, StepTimings = [] }",
new TimingProperty(new(startTime, endTime, duration)).ToString());
}
finally
{
CultureInfo.CurrentCulture = originalCulture;
}
DateTimeOffset startTime = new(2021, 9, 1, 0, 0, 0, default);
DateTimeOffset endTime = new(2021, 9, 1, 1, 2, 3, default);
TimeSpan duration = endTime - startTime;
Assert.AreEqual(
"TimingProperty { GlobalTiming = TimingInfo { StartTime = 09/01/2021 00:00:00 +00:00, EndTime = 09/01/2021 01:02:03 +00:00, Duration = 01:02:03 }, StepTimings = [] }",
new TimingProperty(new(startTime, endTime, duration)).ToString());
}

[TestMethod]
public void TimingProperty_WithStepTimings_ToStringIsCorrect()
{
CultureInfo originalCulture = CultureInfo.CurrentCulture;
try
{
CultureInfo.CurrentCulture = CultureInfo.InvariantCulture;
DateTimeOffset startTime = new(2021, 9, 1, 0, 0, 0, default);
DateTimeOffset endTime = new(2021, 9, 1, 1, 2, 3, default);
TimeSpan duration = endTime - startTime;
Assert.AreEqual(
"TimingProperty { GlobalTiming = TimingInfo { StartTime = 09/01/2021 00:00:00 +00:00, EndTime = 09/01/2021 01:02:03 +00:00, Duration = 01:02:03 }, StepTimings = [StepTimingInfo { Id = run, Description = some description, Timing = TimingInfo { StartTime = 09/01/2021 00:00:00 +00:00, EndTime = 09/01/2021 01:02:03 +00:00, Duration = 01:02:03 } }] }",
new TimingProperty(new(startTime, endTime, duration), [new("run", "some description", new(startTime, endTime, duration))]).ToString());
}
finally
{
CultureInfo.CurrentCulture = originalCulture;
}
DateTimeOffset startTime = new(2021, 9, 1, 0, 0, 0, default);
DateTimeOffset endTime = new(2021, 9, 1, 1, 2, 3, default);
TimeSpan duration = endTime - startTime;
Assert.AreEqual(
"TimingProperty { GlobalTiming = TimingInfo { StartTime = 09/01/2021 00:00:00 +00:00, EndTime = 09/01/2021 01:02:03 +00:00, Duration = 01:02:03 }, StepTimings = [StepTimingInfo { Id = run, Description = some description, Timing = TimingInfo { StartTime = 09/01/2021 00:00:00 +00:00, EndTime = 09/01/2021 01:02:03 +00:00, Duration = 01:02:03 } }] }",
new TimingProperty(new(startTime, endTime, duration), [new("run", "some description", new(startTime, endTime, duration))]).ToString());
}

[TestMethod]
Expand Down
Loading