Skip to content

Speed up token value to name lookup #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Speed up token value to name lookup #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/Token.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,25 @@ public function getEndPosition() {
return $this->fullStart + $this->length;
}

public static function getTokenKindNameFromValue($kindName) {
$constants = (new \ReflectionClass("Microsoft\\PhpParser\\TokenKind"))->getConstants();
foreach ($constants as $name => $val) {
if ($val == $kindName) {
$kindName = $name;
break;
}
/**
* @return string[] - A hash map of the format [int $tokenKind => string $tokenName]
*/
private static function getTokenKindNameFromValueMap() {
static $mapToKindName;
if ($mapToKindName === null) {
$constants = (new \ReflectionClass("Microsoft\\PhpParser\\TokenKind"))->getConstants();
$mapToKindName = \array_flip($constants);
}
return $kindName;
return $mapToKindName;
}

/**
* @param int $kind
* @return string (Or int, if the kind name for $kind wasn't found)
*/
public static function getTokenKindNameFromValue($kind) {
$mapToKindName = self::getTokenKindNameFromValueMap();
return $mapToKindName[$kind] ?? $kind;
}

public function jsonSerialize() {
Expand Down