Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to GeoDataset #75

Merged
merged 8 commits into from
Aug 10, 2021
Merged

Various fixes to GeoDataset #75

merged 8 commits into from
Aug 10, 2021

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Aug 6, 2021

This PR contains fixes to various bugs I've discovered so far in GeoDataset and its subclasses:

  • Landsat: regex now correctly matches B11 filename
  • Landsat/Sentinel: globs now match a single band per scene instead of adding every band to the index
  • RasterDataset: fix shape mismatch errors when trying to concatenate bands of different resolution (Resolution/resampling #74)
  • RasterDataset: fix sampling outside of the bounds of an image resulting in a smaller tensor instead of nodata values
  • RasterDataset: merge overlapping files
  • VectorDataset: merge overlapping files

There are also tests to prevent regressions.

Fixes #74

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Aug 6, 2021
@adamjstewart adamjstewart marked this pull request as draft August 6, 2021 18:12
@adamjstewart adamjstewart marked this pull request as ready for review August 9, 2021 16:09
@calebrob6
Copy link
Member

I didn't review this thoroughly (am mostly out until Thursday) -- feel free to merge if you are confident

@adamjstewart
Copy link
Collaborator Author

Confident that it doesn't introduce any new bugs? No.
Confident that it has fewer bugs than we had before? Yes.

@adamjstewart adamjstewart merged commit 3a00bab into main Aug 10, 2021
@adamjstewart adamjstewart deleted the fixes/geodataset branch August 10, 2021 15:06
@adamjstewart adamjstewart added this to the 0.1.0 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution/resampling
2 participants