fix: allow propertyKey to be undefined

[JorgeLNJunior]

Description

Typescript 5 fixed a bug in the decorator parameter type check that was causing decorators from tsyringe to fail to build. This fix allows for the propertyKey parameter to be undefined.

I'm not an experienced programmer, so if there's something wrong, please let me know.

Fixes: #221

[m-salman-afzal]

any updates on this? Only this is the hinderence while migrating to TS 5😢😢

[k2tomasz]

asked someone from MS to look into it. hopefully they will approve this soon.

[koloboid]

Guys, this needs to be merged asap, the project becomes unusable.

[vajahath]

We might want to tag someone from MS I guess..

[fknop]

@Xapphire13 Hello!
I'm tagging you as you are the main contributor to this project. Is this project still maintained by microsoft? I can see on your Github profile that you no longer work for them. Would there be someone to take over the repository?

[MeltingMosaic]

LGTM

I don't love the idea of propertyKey being undefined, but I'm OK with it as a stop gap until we can get a proper TS 5 version.

[fknop]

Thanks @MeltingMosaic ! Do you know when a new version will be released? :)

[rghermosa]

@MeltingMosaic Do you know when will this be released?
The library is unusable for the newer versions of TS and this supposes a blocker for many people who want to use this library as well

[m-salman-afzal]

@MeltingMosaic Do you know when will this be released? The library is unusable for the newer versions of TS and this supposes a blocker for many people who want to use this library as well

still waiting⌚

[fknop]

For people interested, in the meantime I'm using a patch using patch-package, it's not ideal but it allowed us to upgrade to TS 5.0.

diff --git a/node_modules/tsyringe/dist/typings/decorators/inject-all-with-transform.d.ts b/node_modules/tsyringe/dist/typings/decorators/inject-all-with-transform.d.ts
index 196dfac..1a5764e 100644
--- a/node_modules/tsyringe/dist/typings/decorators/inject-all-with-transform.d.ts
+++ b/node_modules/tsyringe/dist/typings/decorators/inject-all-with-transform.d.ts
@@ -5,5 +5,5 @@ import Transform from "../types/transform";
  *
  * @return {Function} The parameter decorator
  */
-declare function injectAllWithTransform(token: InjectionToken<any>, transformer: InjectionToken<Transform<[any], any>>, ...args: any[]): (target: any, propertyKey: string | symbol, parameterIndex: number) => any;
+declare function injectAllWithTransform(token: InjectionToken<any>, transformer: InjectionToken<Transform<[any], any>>, ...args: any[]): (target: any, propertyKey: string | symbol | undefined, parameterIndex: number) => any;
 export default injectAllWithTransform;
diff --git a/node_modules/tsyringe/dist/typings/decorators/inject-all.d.ts b/node_modules/tsyringe/dist/typings/decorators/inject-all.d.ts
index 2bd7da4..3716ef5 100644
--- a/node_modules/tsyringe/dist/typings/decorators/inject-all.d.ts
+++ b/node_modules/tsyringe/dist/typings/decorators/inject-all.d.ts
@@ -4,5 +4,5 @@ import InjectionToken from "../providers/injection-token";
  *
  * @return {Function} The parameter decorator
  */
-declare function injectAll(token: InjectionToken<any>): (target: any, propertyKey: string | symbol, parameterIndex: number) => any;
+declare function injectAll(token: InjectionToken<any>): (target: any, propertyKey: string | symbol | undefined, parameterIndex: number) => any;
 export default injectAll;
diff --git a/node_modules/tsyringe/dist/typings/decorators/inject-with-transform.d.ts b/node_modules/tsyringe/dist/typings/decorators/inject-with-transform.d.ts
index 05f87d7..47ba138 100644
--- a/node_modules/tsyringe/dist/typings/decorators/inject-with-transform.d.ts
+++ b/node_modules/tsyringe/dist/typings/decorators/inject-with-transform.d.ts
@@ -7,5 +7,5 @@ import Transform from "../types/transform";
  * @param args Arguments to be passed to the transform method on the transformer
  * @returns The parameter decorator
  */
-declare function injectWithTransform(token: InjectionToken<any>, transformer: InjectionToken<Transform<any, any>>, ...args: any[]): (target: any, propertyKey: string | symbol, parameterIndex: number) => any;
+declare function injectWithTransform(token: InjectionToken<any>, transformer: InjectionToken<Transform<any, any>>, ...args: any[]): (target: any, propertyKey: string | symbol | undefined, parameterIndex: number) => any;
 export default injectWithTransform;
diff --git a/node_modules/tsyringe/dist/typings/decorators/inject.d.ts b/node_modules/tsyringe/dist/typings/decorators/inject.d.ts
index 5d48d79..867384c 100644
--- a/node_modules/tsyringe/dist/typings/decorators/inject.d.ts
+++ b/node_modules/tsyringe/dist/typings/decorators/inject.d.ts
@@ -4,5 +4,5 @@ import InjectionToken from "../providers/injection-token";
  *
  * @return {Function} The parameter decorator
  */
-declare function inject(token: InjectionToken<any>): (target: any, propertyKey: string | symbol, parameterIndex: number) => any;
+declare function inject(token: InjectionToken<any>): (target: any, propertyKey: string | symbol | undefined, parameterIndex: number) => any;
 export default inject;
diff --git a/node_modules/tsyringe/dist/typings/reflection-helpers.d.ts b/node_modules/tsyringe/dist/typings/reflection-helpers.d.ts
index 2591a35..4c45940 100644
--- a/node_modules/tsyringe/dist/typings/reflection-helpers.d.ts
+++ b/node_modules/tsyringe/dist/typings/reflection-helpers.d.ts
@@ -7,4 +7,4 @@ export declare function getParamInfo(target: constructor<any>): ParamInfo[];
 export declare function defineInjectionTokenMetadata(data: any, transform?: {
     transformToken: InjectionToken<Transform<any, any>>;
     args: any[];
-}): (target: any, propertyKey: string | symbol, parameterIndex: number) => any;
+}): (target: any, propertyKey: string | symbol | undefined, parameterIndex: number) => any;

[justinlevi]

I see that this PR was merged, do you know when the package.json version will be updated and a release will be published? Thanks

[zckrs]

Hi,

Someone can release a new tag (v4.8.0 maybe) ?

This unrelease change block many people to migrate with TS 5.

cc @MeltingMosaic @EliasBinde @EliTheSurfer

[johan13]

This unrelease change block many people to migrate with TS 5.

I agree that a new release would be good, but the workaround in #225 (comment) works fine in the meantime.

[jhechtf]

It unfortunately does not work for me, as Deno is weirder with modules than Node. Please release the fix.

[tec27]

In case it's useful to anybody else, I have a fork of this repo with this fix included (and compiled files checked in, so it can be used as an npm dependency): https://github.com/tec27/tsyringe

You can use it by changing your package.json dep to:

"tsyringe": "tec27/tsyringe#43d00160db294312db4c7deb38046f71dcd74348"

[tobiasdiez]

Thanks @JorgeLNJunior for this fix. It works like a charm for me!