Fix crash in find-all-refs on exports.xxx in .js file
#2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Nov 5, 2025
| }} | ||
| } | ||
| return nil | ||
| return []*SymbolAndEntries{} |
Member
There was a problem hiding this comment.
What calling code depends on the difference? 😞
Member
Author
There was a problem hiding this comment.
Two places in findallreferences.go. They specifically check for nil and branch accordingly. Ugly, but basically the same behavior with had in Strada (i.e. undefined vs possibly empty array).
Member
Author
There was a problem hiding this comment.
Actually, only one place depends on seeing nil:
jakebailey
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when doing find-all-refs in a .js file: