Skip to content

Fix crash in find-all-refs on exports.xxx in .js file #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

Fix crash in find-all-refs on exports.xxx in .js file #2023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/ls/findallreferences.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ func (l *LanguageService) getReferencedSymbolsForModule(ctx context.Context, pro
references: references,
}}
}
return nil
return []*SymbolAndEntries{}
Copy link
Member

@jakebailey jakebailey Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What calling code depends on the difference? 😞

Copy link
Member Author

@ahejlsberg ahejlsberg Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two places in findallreferences.go. They specifically check for nil and branch accordingly. Ugly, but basically the same behavior with had in Strada (i.e. undefined vs possibly empty array).

Copy link
Member Author

@ahejlsberg ahejlsberg Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, only one place depends on seeing nil:

typescript-go/internal/ls/findallreferences.go

Line 732 in 3d247ef

if moduleReferences != nil && symbol.Flags&ast.SymbolFlagsTransient == 0 {

}

func getReferenceAtPosition(sourceFile *ast.SourceFile, position int, program *compiler.Program) *refInfo {
Expand Down
Loading