From aaaefe9f52683a43378ba2764b1f33a470c11a6c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 15 May 2026 17:21:07 +0000 Subject: [PATCH 1/2] Initial plan From ab15fda22f03b8f7e4201b25d6973fd4e9c6d220 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 15 May 2026 17:27:36 +0000 Subject: [PATCH 2/2] Accept CJS `module.exports = {}` baseline diffs (export = _default with inlined object type) Move 15 diff files from submoduleTriaged to submoduleAccepted for issue #3543. These diffs reflect intentional changes where CJS module.exports = {} patterns now emit export = _default with an inlined object type instead of individual named exports. Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com> --- ...sDeclarationEmitExportAssignedArray.js.diff | 0 ...nedFunctionWithExtraTypedefsMembers.js.diff | 0 .../jsDeclarationsCommonjsRelativePath.js.diff | 0 ...sDocCommentsOnConsts(target=es2015).js.diff | 0 ...ressionPlusSecondary(target=es2015).js.diff | 0 ...nmentWithKeywordName(target=es2015).js.diff | 0 .../jsDeclarationsExportedClassAliases.js.diff | 0 ...mportAliasExposedWithinNamespaceCjs.js.diff | 0 ...nsReexportedCjsAlias(target=es2015).js.diff | 0 ...nsReferenceToClassInstanceCrossFile.js.diff | 0 .../jsDeclarationsTypeAliases.js.diff | 0 ...ationsTypeReferences(target=es2015).js.diff | 0 ...tionsTypeReferences2(target=es2015).js.diff | 0 ...jsDeclarationsTypedefAndImportTypes.js.diff | 0 ...sTypedefPropertyAndExportAssignment.js.diff | 0 testdata/submoduleAccepted.txt | 18 ++++++++++++++++++ testdata/submoduleTriaged.txt | 18 ------------------ 17 files changed, 18 insertions(+), 18 deletions(-) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/compiler/jsDeclarationEmitExportAssignedArray.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsCommonjsRelativePath.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsExportedClassAliases.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsTypeAliases.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsTypeReferences(target=es2015).js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsTypedefAndImportTypes.js.diff (100%) rename testdata/baselines/reference/{submoduleTriaged => submoduleAccepted}/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff (100%) diff --git a/testdata/baselines/reference/submoduleTriaged/compiler/jsDeclarationEmitExportAssignedArray.js.diff b/testdata/baselines/reference/submoduleAccepted/compiler/jsDeclarationEmitExportAssignedArray.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/compiler/jsDeclarationEmitExportAssignedArray.js.diff rename to testdata/baselines/reference/submoduleAccepted/compiler/jsDeclarationEmitExportAssignedArray.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff b/testdata/baselines/reference/submoduleAccepted/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff rename to testdata/baselines/reference/submoduleAccepted/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsCommonjsRelativePath.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsCommonjsRelativePath.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsCommonjsRelativePath.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsCommonjsRelativePath.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsExportedClassAliases.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportedClassAliases.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsExportedClassAliases.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportedClassAliases.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypeAliases.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeAliases.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypeAliases.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeAliases.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypeReferences(target=es2015).js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeReferences(target=es2015).js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypeReferences(target=es2015).js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeReferences(target=es2015).js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypedefAndImportTypes.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypedefAndImportTypes.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypedefAndImportTypes.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypedefAndImportTypes.js.diff diff --git a/testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff similarity index 100% rename from testdata/baselines/reference/submoduleTriaged/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff rename to testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff diff --git a/testdata/submoduleAccepted.txt b/testdata/submoduleAccepted.txt index 975c9c00e44..04a84cadd32 100644 --- a/testdata/submoduleAccepted.txt +++ b/testdata/submoduleAccepted.txt @@ -1382,6 +1382,24 @@ conformance/moduleExportDuplicateAlias2.js.diff conformance/moduleExportDuplicateAlias3.js.diff conformance/moduleExportsElementAccessAssignment.js.diff +# CJS `module.exports = {}` now emits `export = _default` with inlined object type instead of named exports +## https://github.com/microsoft/typescript-go/issues/3543 +compiler/jsDeclarationEmitExportAssignedArray.js.diff +compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff +conformance/jsDeclarationsCommonjsRelativePath.js.diff +conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff +conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff +conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff +conformance/jsDeclarationsExportedClassAliases.js.diff +conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff +conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff +conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff +conformance/jsDeclarationsTypeAliases.js.diff +conformance/jsDeclarationsTypeReferences(target=es2015).js.diff +conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff +conformance/jsDeclarationsTypedefAndImportTypes.js.diff +conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff + # @overload handling changes in JS declaration emit (we no longer support @overload on declarations that can't have TS overloads) ## https://github.com/microsoft/typescript-go/issues/3555 compiler/jsFileAlternativeUseOfOverloadTag.js.diff diff --git a/testdata/submoduleTriaged.txt b/testdata/submoduleTriaged.txt index d5270a4ade9..d79d08cf369 100644 --- a/testdata/submoduleTriaged.txt +++ b/testdata/submoduleTriaged.txt @@ -47,24 +47,6 @@ conformance/nodeModulesAllowJsImportAssignment(module=node18).js.diff conformance/nodeModulesAllowJsImportAssignment(module=node20).js.diff conformance/nodeModulesAllowJsImportAssignment(module=nodenext).js.diff -# CJS `module.exports = {}` now emits `export = _default` with inlined object type instead of named exports -## https://github.com/microsoft/typescript-go/issues/3543 -compiler/jsDeclarationEmitExportAssignedArray.js.diff -compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.js.diff -conformance/jsDeclarationsCommonjsRelativePath.js.diff -conformance/jsDeclarationsDocCommentsOnConsts(target=es2015).js.diff -conformance/jsDeclarationsExportAssignmentWithKeywordName(target=es2015).js.diff -conformance/jsDeclarationsExportedClassAliases.js.diff -conformance/jsDeclarationsExportAssignmentExpressionPlusSecondary(target=es2015).js.diff -conformance/jsDeclarationsReexportedCjsAlias(target=es2015).js.diff -conformance/jsDeclarationsTypeReferences(target=es2015).js.diff -conformance/jsDeclarationsTypeReferences2(target=es2015).js.diff -conformance/jsDeclarationsTypeAliases.js.diff -conformance/jsDeclarationsTypedefAndImportTypes.js.diff -conformance/jsDeclarationsTypedefPropertyAndExportAssignment.js.diff -conformance/jsDeclarationsReferenceToClassInstanceCrossFile.js.diff -conformance/jsDeclarationsImportAliasExposedWithinNamespaceCjs.js.diff - # CJS class expression exports now emit anonymous constructor types instead of named class declarations ## https://github.com/microsoft/typescript-go/issues/3544 conformance/commonJSImportExportedClassExpression.js.diff