Fix Java's handling of mime type text when type is primitive #9007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
XiaofeiCao,
anuchandy,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:java
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
weidongxu-microsoft
approved these changes
Nov 17, 2025
...m/microsoft/typespec/http/client/generator/core/template/ConvenienceAsyncMethodTemplate.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case in Java's generator when handling
BinaryData-> primitive type conversion where it would default toBinaryData.toString(). This failed for primitive types as aStringdoesn't implicitly cast toboolean,byte,int,long,float,double, orchar.This is fixed by checking the raw return type for being
!isNullable()(only primitives return true for this) and wrapping theBinaryData.toString()logic withString-> primitive conversion calls (Long.parseLong(String),Byte.parseByte(String), etc).Updated
response.tspto include new routes to test this change.