Skip to content

[http specs] Add new test case for multipart #9139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
msyyc wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[http specs] Add new test case for multipart #9139

msyyc wants to merge 11 commits into from

Conversation

@msyyc
Copy link
Contributor

@msyyc msyyc commented Dec 4, 2025 •
edited
Loading

Add test case to cover scenarios of #9137 and #9136

This PR adds 2 cases:

  • set different wire name for http part
  • make file part optional

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 4, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http@9139

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client@9139

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client-js@9139

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-specs@9139

commit: dbcbe03

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-client-js
  • ✅ @typespec/http-specs
Show changes

@typespec/http-specs - feature ✏️

Add new test case for multipart

@typespec/http-client-js - internal ✏️

skip multipart test case until bug is fixed to unblock new spector case merge

@msyyc msyyc mentioned this pull request Dec 4, 2025
Merged
1 task
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 4, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@msyyc msyyc marked this pull request as ready for review December 5, 2025 05:29
@msyyc
Copy link
Contributor Author

msyyc commented Dec 5, 2025 •
edited
Loading

The CI failure seems related with http-client-js which can't handle the new test case:

image CC. @MaryGao

@msyyc msyyc mentioned this pull request Dec 5, 2025
Merged
1 task
@msyyc msyyc added the lib:http-specs For issues/prs related to the @typespec/http-specs package label Dec 5, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@msyyc
[Python] Fix serialization name for multipart (#9138)
7af8f6d 
fix #9137

Related PR: 
- [ ] #9139
@MaryGao
Copy link
Member

MaryGao commented Dec 8, 2025 •
edited
Loading

The CI failure seems related with http-client-js which can't handle the new test case:

image CC. @MaryGao

@msyyc there are some generation issues for new cases. Could you help add them into ignore file? https://github.com/microsoft/typespec/blob/main/packages/http-client-js/.testignore

github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@msyyc
[Python] Fix multipart when files part is optional (#9144)
27036b8 
fix #9136

Related PR:
- [ ] #9139
@msyyc msyyc mentioned this pull request Dec 8, 2025
Open
msyyc
msyyc commented Dec 9, 2025
View reviewed changes
packages/http-client-js/test/e2e/http/payload/multipart/main.test.ts
const pngContents = new Uint8Array(pngBuffer);

describe("Payload.MultiPart", () => {
describe.skip("Payload.MultiPart", () => {
Copy link
Contributor Author

@msyyc msyyc Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #9155 fixed, js could revert the change.
CC @MaryGao

Copy link
Member

@MaryGao MaryGao Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joheredi the new mfd cases would fail the generation so here we skip the whold mfd cases. issue is tracked here: #9155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@timovv timovv Awaiting requested review from timovv timovv is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

lib:http-specs For issues/prs related to the @typespec/http-specs package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msyyc @azure-sdk @MaryGao