Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fault injection to CICD #118

Merged
merged 12 commits into from
Sep 16, 2023
Merged

Add fault injection to CICD #118

merged 12 commits into from
Sep 16, 2023

Conversation

dthaler
Copy link
Contributor

@dthaler dthaler commented Sep 13, 2023 •
edited
Loading

  • Add cxplat_test to the VS CI/CD workflow
  • Fix cxplat memory initialization test on Release builds were uninitialized memory isn't necessarily non-zero
  • Add missing file to the cxplat test and winuser CMakeLists.txt files (fixes cxplat_test CMakeList is missing several test cpp files #120)
  • Temporarily switch from using Catch2 as a nuget package to using it as a submodule to get the later version that supports --verbosity=quiet for the console reporter. We can switch back once the Catch2 nuget package supports it.
  • Move cxplat_passed_test_log.h out of the ebpf-for-windows repository to here. It's required by the Test-FaultInjection.ps1 script which was previously moved here but the header file wasn't moved then.
  • Add docs to the README file on how to use fault injection.

Fixes #37

@dthaler
Add fault injection to CICD
93ecd7c 
Addresses more of #37

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Fix cmake CI/CD workflow
bf9815a 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
More cicd fixes
58d0178 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Fix cxplat memory allocation test on Release builds
5584187 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
CI/CD fixes
d81ef01 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Expand test timeout
063cc0c 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Fix leak in WDF test
942b3f8 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Fix leak in mm test
352bec5 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Restore max CI/CD test timeout to original size
6fc02e0 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Remove unnessary change
5c10c5a 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Add docs on how to use fault injection
02887d4 
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler
Merge branch 'main' into fault
0eb2d09
@dthaler dthaler mentioned this pull request Sep 13, 2023
Closed
4 tasks
nibanks
nibanks reviewed Sep 16, 2023
View reviewed changes
cxplat/cxplat_test/cxplat_memory_test.cpp
Comment on lines +19 to +21
#ifndef NDEBUG
REQUIRE(*buffer != 0);
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth defining a wrapper for REQUIRE instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't seem worth it yet, but if I add more, then I will.

nibanks
nibanks approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise looks good.

@dthaler dthaler merged commit db4348c into main Sep 16, 2023
5 checks passed
@dthaler dthaler deleted the fault branch September 16, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibanks nibanks nibanks approved these changes

@Alan-Jowett Alan-Jowett Awaiting requested review from Alan-Jowett Alan-Jowett is a code owner

@mtfriesen mtfriesen Awaiting requested review from mtfriesen mtfriesen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cxplat_test CMakeList is missing several test cpp files Add fault injection to README and CI/CD
2 participants
@dthaler @nibanks