Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported platform added for env (fixes #29559) #891

Merged
merged 6 commits into from Feb 13, 2023

Conversation

soroshsabz
Copy link
Contributor

@soroshsabz soroshsabz commented Feb 9, 2023

ITNOA

I correct error message for vcpkg env command in Linux. fixes #29559 microsoft/vcpkg#29559

@soroshsabz soroshsabz changed the title Unsupported platform added for env (fixes #29559) Unsupported platform added for env (fixes #29558) Feb 9, 2023
@soroshsabz soroshsabz changed the title Unsupported platform added for env (fixes #29558) Unsupported platform added for env (fixes #29559) Feb 9, 2023
@soroshsabz
Copy link
Contributor Author

@BillyONeal please review this PR

thanks :)

src/vcpkg/commands.env.cpp Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

Thanks for your contribution!

@soroshsabz
Copy link
Contributor Author

@BillyONeal I localized message.

Please review again

@soroshsabz soroshsabz requested review from BillyONeal and removed request for JackBoosY February 11, 2023 14:36
@soroshsabz
Copy link
Contributor Author

@BillyONeal Thanks for review it, so How to merge it? :D

@BillyONeal BillyONeal merged commit 0798425 into microsoft:main Feb 13, 2023
@BillyONeal
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants