Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl2-mixer[mpg123]] incorrect build on Windows #8429

Closed
tannergooding opened this issue Oct 2, 2019 · 3 comments

Comments

@tannergooding
Copy link
Member

commented Oct 2, 2019

Host Environment

  • OS: Windows 10 1903, x64
  • Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.24.28103

To Reproduce
Steps to reproduce the behavior:

  • .\vcpkg.exe install sdl2-mixer[mpg123]
    • Same applies for the other extensions [libflac], [libmodplug], [libvorbis], and [opusfile]
  • Check the build output logs (.\buildtrees\sdl2-mixer\install-x64-windows-debg-out.log
  • Observe that MPG123_DYNAMIC is set to effectively .\installed\x64-windows\debug\lib\libmpg123.lib"
    • -DMPG123_DYNAMIC=\"C:/repos/vcpkg/installed/x64-windows/debug/lib/libmpg123.lib\"

Expected Behavior
The build should be setting this to the dynamic link library libmpg123.dll, rather than the static link library (unless explicitly building with static linking in mind) and should not be resolving the full path to this library (it should instead, likely, be using the relative name and relying on the OS resolution logic to find it).

This ultimately looks to be because the root CMakeLists.txt file (https://github.com/microsoft/vcpkg/blob/master/ports/sdl2-mixer/CMakeLists.txt ) is accounting for this and instead just returns whatever find_library resolves.

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

FYI. @JackBoosY, as it looks like this is fallout from #8335

@JackBoosY JackBoosY self-assigned this Oct 3, 2019
@JackBoosY

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@tannergooding It's make sense.

@JackBoosY

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Hi @tannergooding, thanks for reporting this issue.
I've fixed this issue, please update vcpkg and rebuild sdl2-mixer.
I wish it's the last fix :)

Thanks.

@JackBoosY JackBoosY closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.